From 1fbb5005c50a85fb702cf171f00344d0a3b83a3f Mon Sep 17 00:00:00 2001 From: jmoenig Date: Wed, 7 Oct 2020 09:37:45 +0200 Subject: [PATCH] fixed an empty-slot detection issue fixed an empty-slot detection issue (reported in the forums), but left it commented out for now, until researching the consequences ;-) --- HISTORY.md | 1 + snap.html | 2 +- src/blocks.js | 5 ++++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index f350e335..506dccb7 100755 --- a/HISTORY.md +++ b/HISTORY.md @@ -21,6 +21,7 @@ ### 2020-10-07 * byob: added "settings" button to input slot dialog * symbols: added "gearPartial" icon +* blocks: fixed an empty-slot detection issue (reported in the forums), but left it commented out for now, until researching the consequences ;-) ### 2020-10-06 * blocks: disable blurred shadows inside input slots if the hidden "blurred shadows" setting is turned off diff --git a/snap.html b/snap.html index 12fcfb80..0f17b523 100755 --- a/snap.html +++ b/snap.html @@ -8,7 +8,7 @@ - + diff --git a/src/blocks.js b/src/blocks.js index 0b583669..feacf136 100644 --- a/src/blocks.js +++ b/src/blocks.js @@ -158,7 +158,7 @@ CustomCommandBlockMorph, SymbolMorph, ToggleButtonMorph, DialMorph*/ // Global stuff //////////////////////////////////////////////////////// -modules.blocks = '2020-October-06'; +modules.blocks = '2020-October-07'; var SyntaxElementMorph; var BlockMorph; @@ -388,6 +388,9 @@ SyntaxElementMorph.prototype.allEmptySlots = function () { // to empty input slots var empty = []; if (!(this instanceof RingMorph) && + // disregard custom C-slots, because they should be treated as + // rings. Commented out for now... + // !(this instanceof CSlotMorph && !this.isStatic) && (this.selector !== 'reportJSFunction')) { this.children.forEach(morph => { if (morph.isEmptySlot && morph.isEmptySlot()) {