Correctly handle response.raise_for_status() and guard search from bubbling parse errors (#322)

activities/services/search.py

@@ -41,15 +41,18 @@ class SearchService:
                     username__iexact=username,
                 )
             except Identity.DoesNotExist:
+                identity = None
                 if self.identity is not None:
-                    # Allow authenticated users to fetch remote
+                    try:
-                    identity = Identity.by_username_and_domain(
+                        # Allow authenticated users to fetch remote
-                        username, domain_instance or domain, fetch=True
+                        identity = Identity.by_username_and_domain(
-                    )
+                            username, domain_instance or domain, fetch=True
-                    if identity and identity.state == IdentityStates.outdated:
+                        )
-                        async_to_sync(identity.fetch_actor)()
+                        if identity and identity.state == IdentityStates.outdated:
-                else:
+                            async_to_sync(identity.fetch_actor)()
-                    identity = None
+                    except ValueError:
+                        pass
+
             if identity:
                 results.add(identity)
 

users/models/identity.py

@@ -640,7 +640,7 @@ class Identity(StatorModel):
                     headers={"Accept": "application/json"},
                 )
                 response.raise_for_status()
-            except httpx.RequestError as ex:
+            except httpx.HTTPError as ex:
                 response = getattr(ex, "response", None)
                 if (
                     response