added comments to clarify the toggling of the LED state on startup issue

pull/40/head
John Tsiombikas 2021-05-23 00:44:41 +03:00
rodzic 6972066793
commit 6bd07cf0f6
1 zmienionych plików z 10 dodań i 1 usunięć

Wyświetl plik

@ -181,7 +181,16 @@ int open_dev_usb(struct device *dev)
if(cfg.led == LED_ON || (cfg.led == LED_AUTO && first_client())) {
set_led_evdev(dev, 1);
} else {
/* required on some devices to turn off led after plugging in */
/* Some devices start with the LED enabled, make sure to turn it off
* explicitly if necessary.
*
* XXX G.Ebner reports that some devices (SpaceMouse Compact at least)
* fail to turn their LED off at startup if it's not turned explicitly
* on first. We'll need to investigate further, but it doesn't seem to
* cause any visible blinking, so let's leave the redundant call to
* enable it first for now. See github pull request #39:
* https://github.com/FreeSpacenav/spacenavd/pull/39
*/
set_led_evdev(dev, 1);
set_led_evdev(dev, 0);
}