From 3094c87b0afaa4c8eb86fd7c186804a6de80efbb Mon Sep 17 00:00:00 2001
From: Conor Patrick <conorpp94@gmail.com>
Date: Mon, 22 Apr 2019 16:25:08 -0400
Subject: [PATCH] Test empty pinAuth in MC and GA #179

---
 tools/testing/tests/fido2.py | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tools/testing/tests/fido2.py b/tools/testing/tests/fido2.py
index cbb4de7..fc27cfd 100644
--- a/tools/testing/tests/fido2.py
+++ b/tools/testing/tests/fido2.py
@@ -1069,9 +1069,45 @@ class FIDO2Tests(Tester):
 
         self.testReset()
 
+        with Test("Test sending zero-length pin_auth, expect PIN_NOT_SET"):
+            self.testMC(
+                "Send MC request with new pin auth",
+                cdh,
+                rp,
+                user,
+                key_params,
+                other={"pin_auth": b"", "pin_protocol": pin_protocol},
+                expectedError=CtapError.ERR.PIN_NOT_SET,
+            )
+            self.testGA(
+                "Send MC request with new pin auth",
+                rp["id"],
+                cdh,
+                other={"pin_auth": b"", "pin_protocol": pin_protocol},
+                expectedError=CtapError.ERR.PIN_NOT_SET,
+            )
+
         with Test("Setting pin code, expect SUCCESS"):
             self.client.pin_protocol.set_pin(pin1)
 
+        with Test("Test sending zero-length pin_auth, expect PIN_INVALID"):
+            self.testMC(
+                "Send MC request with new pin auth",
+                cdh,
+                rp,
+                user,
+                key_params,
+                other={"pin_auth": b"", "pin_protocol": pin_protocol},
+                expectedError=CtapError.ERR.PIN_INVALID,
+            )
+            self.testGA(
+                "Send MC request with new pin auth",
+                rp["id"],
+                cdh,
+                other={"pin_auth": b"", "pin_protocol": pin_protocol},
+                expectedError=CtapError.ERR.PIN_INVALID,
+            )
+
         self.testReset()
         with Test("Setting pin code >63 bytes, expect POLICY_VIOLATION "):
             try: