From 764bfcc3091ab38dc60546357ec3953bbc41b17f Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Thu, 6 Apr 2023 17:41:25 +0200
Subject: [PATCH] Fix dashboard vue

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 lib/AppInfo/Application.php      |  2 +-
 src/components/TimelineEntry.vue | 30 ++------------
 src/components/TimelinePost.vue  |  2 +-
 src/dashboard.js                 |  5 ++-
 src/services/notifications.js    | 32 +++++++++++++++
 src/views/Dashboard.vue          | 69 +++++++++++++-------------------
 6 files changed, 70 insertions(+), 70 deletions(-)
 create mode 100644 src/services/notifications.js

diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
index b7fac6c7..7ef42a73 100644
--- a/lib/AppInfo/Application.php
+++ b/lib/AppInfo/Application.php
@@ -60,7 +60,7 @@ class Application extends App implements IBootstrap {
 		$context->registerSearchProvider(UnifiedSearchProvider::class);
 		$context->registerWellKnownHandler(WebfingerHandler::class);
 		$context->registerEventListener(BeforeTemplateRenderedEvent::class, ProfileSectionListener::class);
-//		$context->registerDashboardWidget(SocialWidget::class);
+		$context->registerDashboardWidget(SocialWidget::class);
 	}
 
 	public function boot(IBootContext $context): void {
diff --git a/src/components/TimelineEntry.vue b/src/components/TimelineEntry.vue
index 86aa58a7..2c641ebe 100644
--- a/src/components/TimelineEntry.vue
+++ b/src/components/TimelineEntry.vue
@@ -34,11 +34,12 @@
 </template>
 
 <script>
+import Bell from 'vue-material-design-icons/Bell.vue'
+import { translate } from '@nextcloud/l10n'
 import TimelinePost from './TimelinePost.vue'
 import TimelineAvatar from './TimelineAvatar.vue'
 import UserEntry from './UserEntry.vue'
-import Bell from 'vue-material-design-icons/Bell.vue'
-import { translate } from '@nextcloud/l10n'
+import { notificationSummary } from '../services/notifications.js'
 
 export default {
 	name: 'TimelineEntry',
@@ -102,30 +103,7 @@ export default {
 		 * @return {string}
 		 */
 		actionSummary() {
-			switch (this.notification.type) {
-			case 'mention':
-				return t('social', '{account} mentioned you', { account: this.notification.account.acct })
-			case 'status':
-				return t('social', '{account} posted a status', { account: this.notification.account.acct })
-			case 'reblog':
-				return t('social', '{account} boosted your post', { account: this.notification.account.acct })
-			case 'follow':
-				return t('social', '{account} started to follow you', { account: this.notification.account.acct })
-			case 'follow_request':
-				return t('social', '{account} requested to follow you', { account: this.notification.account.acct })
-			case 'favourite':
-				return t('social', '{account} liked your post', { account: this.notification.account.acct })
-			case 'poll':
-				return t('social', '{account} ended the poll', { account: this.notification.account.acct })
-			case 'update':
-				return t('social', '{account} edited a status', { account: this.notification.account.acct })
-			case 'admin.sign_up':
-				return t('social', '{account} signed up', { account: this.notification.account.acct })
-			case 'admin.report':
-				return t('social', '{account} filed a report', { account: this.notification.account.acct })
-			default:
-				return ''
-			}
+			return notificationSummary(this.notification)
 		},
 	},
 	methods: {
diff --git a/src/components/TimelinePost.vue b/src/components/TimelinePost.vue
index 0ce4538a..5d504788 100644
--- a/src/components/TimelinePost.vue
+++ b/src/components/TimelinePost.vue
@@ -208,10 +208,10 @@ export default {
 		getSinglePostTimeline(e) {
 			// Display internal or external post
 			if (!this.isLocal) {
+				// TODO - fix
 				if (this.type === 'Note') {
 					window.open(this.item.id)
 				} else if (this.type === 'Announce') {
-					// TODO
 					window.open(this.item.object)
 				} else {
 					logger.warn("Don't know what to do with posts of type " + this.type, { post: this.item })
diff --git a/src/dashboard.js b/src/dashboard.js
index bb0adbc5..56a6b1a3 100644
--- a/src/dashboard.js
+++ b/src/dashboard.js
@@ -26,8 +26,11 @@ Vue.prototype.OC = window.OC
 document.addEventListener('DOMContentLoaded', function() {
 	OCA.Dashboard.register('social_notifications', (el, { widget }) => {
 		const View = Vue.extend(Dashboard)
+		/* eslint-disable-next-line no-new */
 		new View({
 			propsData: { title: widget.title },
-		}).$mount(el)
+			el,
+			name: 'SocialDashboard',
+		})
 	})
 })
diff --git a/src/services/notifications.js b/src/services/notifications.js
new file mode 100644
index 00000000..44a2b7bc
--- /dev/null
+++ b/src/services/notifications.js
@@ -0,0 +1,32 @@
+import { translate } from '@nextcloud/l10n'
+
+/**
+ * @param {import("../types/Mastodon").Notification} notification
+ * @return {string}
+ */
+export function notificationSummary(notification) {
+	switch (notification.type) {
+	case 'mention':
+		return translate('social', '{account} mentioned you', { account: notification.account.acct })
+	case 'status':
+		return translate('social', '{account} posted a status', { account: notification.account.acct })
+	case 'reblog':
+		return translate('social', '{account} boosted your post', { account: notification.account.acct })
+	case 'follow':
+		return translate('social', '{account} started to follow you', { account: notification.account.acct })
+	case 'follow_request':
+		return translate('social', '{account} requested to follow you', { account: notification.account.acct })
+	case 'favourite':
+		return translate('social', '{account} liked your post', { account: notification.account.acct })
+	case 'poll':
+		return translate('social', '{account} ended the poll', { account: notification.account.acct })
+	case 'update':
+		return translate('social', '{account} edited a status', { account: notification.account.acct })
+	case 'admin.sign_up':
+		return translate('social', '{account} signed up', { account: notification.account.acct })
+	case 'admin.report':
+		return translate('social', '{account} filed a report', { account: notification.account.acct })
+	default:
+		return ''
+	}
+}
diff --git a/src/views/Dashboard.vue b/src/views/Dashboard.vue
index dab943e9..adc155b8 100644
--- a/src/views/Dashboard.vue
+++ b/src/views/Dashboard.vue
@@ -47,6 +47,7 @@ import { generateUrl } from '@nextcloud/router'
 import { showError } from '@nextcloud/dialogs'
 import NcDashboardWidget from '@nextcloud/vue/dist/Components/NcDashboardWidget.js'
 import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent.js'
+import { notificationSummary } from '../services/notifications.js'
 
 export default {
 	name: 'Dashboard',
@@ -121,25 +122,19 @@ export default {
 	},
 
 	methods: {
-		fetchNotifications() {
-			const req = {
-				params: {
-					limit: 10,
-				},
-			}
-			const url = generateUrl('/apps/social/api/v1/stream/notifications')
-			// TODO check why 'since' param is in fact 'until'
-			/* if (this.lastDate) {
-				req.params.since = this.lastTimestamp,
-			} */
-			axios.get(url, req).then((response) => {
-				if (response.data?.result) {
-					this.processNotifications(response.data.result)
+		async fetchNotifications() {
+			const url = generateUrl('apps/social/api/v1/notifications')
+
+			try {
+
+				const response = await axios.get(url)
+				if (response.data) {
+					this.processNotifications(response.data)
 					this.state = 'ok'
 				} else {
 					this.state = 'error'
 				}
-			}).catch((error) => {
+			} catch (error) {
 				clearInterval(this.loop)
 				if (error.response?.status && error.response.status >= 400) {
 					showError(t('social', 'Failed to get Social notifications'))
@@ -148,8 +143,9 @@ export default {
 					// there was an error in notif processing
 					console.error(error)
 				}
-			})
+			}
 		},
+		/** @param {import('../types/Mastodon.js').Notification[]} newNotifications */
 		processNotifications(newNotifications) {
 			if (this.lastTimestamp !== 0) {
 				// just add those which are more recent than our most recent one
@@ -166,55 +162,46 @@ export default {
 				this.notifications = this.filter(newNotifications)
 			}
 		},
+		/** @param {import('../types/Mastodon.js').Notification[]} notifications */
 		filter(notifications) {
 			return notifications
-			// TODO check if we need to filter
-			/* return notifications.filter((n) => {
-				return (n.type === 'something' || n.subtype === 'somethingElse')
-			}) */
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getMainText(n) {
-			if (n.subtype === 'Follow') {
-				return t('social', '{account} is following you', { account: this.getActorName(n) })
-			}
-			if (n.subtype === 'Like') {
-				return t('social', '{account} liked your post', { account: this.getActorName(n) })
-			}
+			return notificationSummary(n)
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getAvatarUrl(n) {
-			return undefined
-			// TODO get external and internal avatars
-			/* return this.getActorAccountName(n)
-				? generateUrl('???')
-				: undefined */
+			return n.account.avatar
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getActorName(n) {
-			return n.actor_info && n.actor_info.type === 'Person' && n.actor_info.preferredUsername
-				? n.actor_info.preferredUsername
-				: ''
+			return n.account.display_name
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getActorAccountName(n) {
-			return n.actor_info && n.actor_info.type === 'Person' && n.actor_info.account
-				? n.actor_info.account
-				: ''
+			return n.account.acct
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getNotificationTarget(n) {
-			if (n.subtype === 'Follow') {
+			if (n.type === 'follow') {
 				return generateUrl('/apps/social/@' + this.getActorAccountName(n) + '/')
 			}
 			return this.showMoreUrl
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getSubline(n) {
-			if (n.subtype === 'Follow') {
+			if (n.type === 'follow') {
 				return this.getActorAccountName(n)
 			}
-			if (n.subtype === 'Like') {
+			if (n.type === 'favourite') {
 				return this.getActorAccountName(n)
 			}
 			return ''
 		},
+		/** @param {import('../types/Mastodon.js').Notification} n */
 		getNotificationTypeImage(n) {
-			if (n.subtype === 'Follow') {
+			if (n.type === 'follow') {
 				return generateUrl('/svg/social/add_user')
 			}
 			return ''