AccountTimeline: let it be configurable like other timelines

app/soapbox/actions/settings.js

@@ -127,6 +127,12 @@ export const defaultSettings = ImmutableMap({
     }),
   }),
 
+  account_timeline: ImmutableMap({
+    shows: ImmutableMap({
+      reblog: true,
+    }),
+  }),
+
   trends: ImmutableMap({
     show: true,
   }),

app/soapbox/features/account_timeline/components/column_settings.js

@@ -0,0 +1,28 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import ImmutablePropTypes from 'react-immutable-proptypes';
+import { injectIntl, FormattedMessage } from 'react-intl';
+import SettingToggle from '../../notifications/components/setting_toggle';
+
+export default @injectIntl
+class ColumnSettings extends React.PureComponent {
+
+  static propTypes = {
+    settings: ImmutablePropTypes.map.isRequired,
+    onChange: PropTypes.func.isRequired,
+    intl: PropTypes.object.isRequired,
+  };
+
+  render() {
+    const { settings, onChange } = this.props;
+
+    return (
+      <div>
+        <div className='column-settings__row'>
+          <SettingToggle prefix='account_timeline' settings={settings} settingPath={['shows', 'reblog']} onChange={onChange} label={<FormattedMessage id='home.column_settings.show_reblogs' defaultMessage='Show reposts' />} />
+        </div>
+      </div>
+    );
+  }
+
+}

app/soapbox/features/account_timeline/containers/column_settings_container.js

@@ -0,0 +1,17 @@
+import { connect } from 'react-redux';
+import ColumnSettings from '../components/column_settings';
+import { getSettings, changeSetting } from '../../../actions/settings';
+
+const mapStateToProps = state => ({
+  settings: getSettings(state).get('account_timeline'),
+});
+
+const mapDispatchToProps = (dispatch) => {
+  return {
+    onChange(key, checked) {
+      dispatch(changeSetting(['account_timeline', ...key], checked));
+    },
+  };
+};
+
+export default connect(mapStateToProps, mapDispatchToProps)(ColumnSettings);

app/soapbox/features/account_timeline/index.js

@@ -15,47 +15,54 @@ import MissingIndicator from 'soapbox/components/missing_indicator';
 import { NavLink } from 'react-router-dom';
 import { fetchPatronAccount } from '../../actions/patron';
 import { getSoapboxConfig } from 'soapbox/actions/soapbox';
+import { makeGetStatusIds } from 'soapbox/selectors';
 
-const mapStateToProps = (state, { params, withReplies = false }) => {
+const makeMapStateToProps = () => {
-  const username = params.username || '';
+  const getStatusIds = makeGetStatusIds();
-  const me = state.get('me');
-  const accounts = state.getIn(['accounts']);
-  const accountFetchError = (state.getIn(['accounts', -1, 'username'], '').toLowerCase() === username.toLowerCase());
-  const soapboxConfig = getSoapboxConfig(state);
 
-  let accountId = -1;
+  const mapStateToProps = (state, { params, withReplies = false }) => {
-  let accountUsername = username;
+    const username = params.username || '';
-  let accountApId = null;
+    const me = state.get('me');
-  if (accountFetchError) {
+    const accounts = state.getIn(['accounts']);
-    accountId = null;
+    const accountFetchError = (state.getIn(['accounts', -1, 'username'], '').toLowerCase() === username.toLowerCase());
-  } else {
+    const soapboxConfig = getSoapboxConfig(state);
-    const account = accounts.find(acct => username.toLowerCase() === acct.getIn(['acct'], '').toLowerCase());
-    accountId = account ? account.getIn(['id'], null) : -1;
-    accountUsername = account ? account.getIn(['acct'], '') : '';
-    accountApId = account ? account.get('url') : '';
-  }
 
-  const path = withReplies ? `${accountId}:with_replies` : accountId;
+    let accountId = -1;
+    let accountUsername = username;
+    let accountApId = null;
+    if (accountFetchError) {
+      accountId = null;
+    } else {
+      const account = accounts.find(acct => username.toLowerCase() === acct.getIn(['acct'], '').toLowerCase());
+      accountId = account ? account.getIn(['id'], null) : -1;
+      accountUsername = account ? account.getIn(['acct'], '') : '';
+      accountApId = account ? account.get('url') : '';
+    }
 
-  const isBlocked = state.getIn(['relationships', accountId, 'blocked_by'], false);
+    const path = withReplies ? `${accountId}:with_replies` : accountId;
-  const unavailable = (me === accountId) ? false : isBlocked;
 
-  return {
+    const isBlocked = state.getIn(['relationships', accountId, 'blocked_by'], false);
-    accountId,
+    const unavailable = (me === accountId) ? false : isBlocked;
-    unavailable,
+
-    accountUsername,
+    return {
-    accountApId,
+      accountId,
-    isAccount: !!state.getIn(['accounts', accountId]),
+      unavailable,
-    statusIds: state.getIn(['timelines', `account:${path}`, 'items'], ImmutableOrderedSet()),
+      accountUsername,
-    featuredStatusIds: withReplies ? ImmutableOrderedSet() : state.getIn(['timelines', `account:${accountId}:pinned`, 'items'], ImmutableOrderedSet()),
+      accountApId,
-    isLoading: state.getIn(['timelines', `account:${path}`, 'isLoading']),
+      isAccount: !!state.getIn(['accounts', accountId]),
-    hasMore: state.getIn(['timelines', `account:${path}`, 'hasMore']),
+      statusIds: getStatusIds(state, { type: `account:${path}`, prefix: 'account_timeline' }),
-    me,
+      featuredStatusIds: withReplies ? ImmutableOrderedSet() : getStatusIds(state, { type: `account:${accountId}:pinned`, prefix: 'account_timeline' }),
-    patronEnabled: soapboxConfig.getIn(['extensions', 'patron', 'enabled']),
+      isLoading: state.getIn(['timelines', `account:${path}`, 'isLoading']),
+      hasMore: state.getIn(['timelines', `account:${path}`, 'hasMore']),
+      me,
+      patronEnabled: soapboxConfig.getIn(['extensions', 'patron', 'enabled']),
+    };
   };
+
+  return mapStateToProps;
 };
 
-export default @connect(mapStateToProps)
+export default @connect(makeMapStateToProps)
 class AccountTimeline extends ImmutablePureComponent {
 
   static propTypes = {

app/soapbox/features/community_timeline/components/column_settings.js

@@ -18,10 +18,6 @@ class ColumnSettings extends React.PureComponent {
 
     return (
       <div>
-        <div className='column-settings__row'>
-          <SettingToggle prefix='community_timeline' settings={settings} settingPath={['shows', 'reblog']} onChange={onChange} label={<FormattedMessage id='home.column_settings.show_reblogs' defaultMessage='Show reposts' />} />
-        </div>
-
         <div className='column-settings__row'>
           <SettingToggle prefix='community_timeline' settings={settings} settingPath={['shows', 'reply']} onChange={onChange} label={<FormattedMessage id='home.column_settings.show_replies' defaultMessage='Show replies' />} />
         </div>

app/soapbox/features/ui/containers/status_list_container.js

@@ -1,25 +1,10 @@
 import { connect } from 'react-redux';
 import StatusList from '../../../components/status_list';
-import { Map as ImmutableMap, OrderedSet as ImmutableOrderedSet } from 'immutable';
+import { OrderedSet as ImmutableOrderedSet } from 'immutable';
-import { createSelector } from 'reselect';
+import { makeGetStatusIds } from 'soapbox/selectors';
 import { debounce } from 'lodash';
 import { dequeueTimeline } from 'soapbox/actions/timelines';
 import { scrollTopTimeline } from '../../../actions/timelines';
-import { getSettings } from 'soapbox/actions/settings';
-import { shouldFilter } from 'soapbox/utils/timelines';
-
-const makeGetStatusIds = () => createSelector([
-  (state, { type }) => getSettings(state).get(type, ImmutableMap()),
-  (state, { type }) => state.getIn(['timelines', type, 'items'], ImmutableOrderedSet()),
-  (state)           => state.get('statuses'),
-  (state)           => state.get('me'),
-], (columnSettings, statusIds, statuses, me) => {
-  return statusIds.filter(id => {
-    const status = statuses.get(id);
-    if (!status) return true;
-    return !shouldFilter(status, columnSettings);
-  });
-});
 
 const makeMapStateToProps = () => {
   const getStatusIds = makeGetStatusIds();

app/soapbox/selectors/index.js

@@ -6,6 +6,8 @@ import {
 } from 'immutable';
 import { getDomain } from 'soapbox/utils/accounts';
 import ConfigDB from 'soapbox/utils/config_db';
+import { getSettings } from 'soapbox/actions/settings';
+import { shouldFilter } from 'soapbox/utils/timelines';
 
 const getAccountBase         = (state, id) => state.getIn(['accounts', id], null);
 const getAccountCounters     = (state, id) => state.getIn(['accounts_counters', id], null);
@@ -262,3 +264,16 @@ export const makeGetRemoteInstance = () => {
     });
   });
 };
+
+export const makeGetStatusIds = () => createSelector([
+  (state, { type, prefix }) => getSettings(state).get(prefix || type, ImmutableMap()),
+  (state, { type }) => state.getIn(['timelines', type, 'items'], ImmutableOrderedSet()),
+  (state)           => state.get('statuses'),
+  (state)           => state.get('me'),
+], (columnSettings, statusIds, statuses, me) => {
+  return statusIds.filter(id => {
+    const status = statuses.get(id);
+    if (!status) return true;
+    return !shouldFilter(status, columnSettings);
+  });
+});