From 49ba4c7a9d811b6d5ca7f04e9ad38bc8b3c830c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?marcin=20miko=C5=82ajczak?= Date: Mon, 6 Feb 2023 18:18:49 +0100 Subject: [PATCH] Fixes, styles improvements, cleanup, enforce classes order for classNames MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: marcin mikołajczak --- .eslintrc.cjs | 5 +- app/soapbox/components/account.tsx | 2 +- .../components/announcements/reaction.tsx | 4 +- app/soapbox/components/autosuggest-input.tsx | 2 +- .../components/autosuggest-textarea.tsx | 2 +- app/soapbox/components/badge.tsx | 2 +- .../components/emoji-button-wrapper.tsx | 9 +- app/soapbox/components/emoji-selector.tsx | 91 +--- app/soapbox/components/error-boundary.tsx | 8 +- app/soapbox/components/event-preview.tsx | 4 +- app/soapbox/components/group-card.tsx | 6 +- app/soapbox/components/landing-gradient.tsx | 2 +- app/soapbox/components/link.tsx | 2 +- app/soapbox/components/list.tsx | 2 +- app/soapbox/components/outline-box.tsx | 2 +- app/soapbox/components/polls/poll-option.tsx | 12 +- app/soapbox/components/radio.tsx | 2 +- app/soapbox/components/scroll-top-button.tsx | 4 +- app/soapbox/components/sidebar-menu.tsx | 8 +- .../components/status-action-button.tsx | 4 +- app/soapbox/components/still-image.tsx | 4 +- .../components/ui/accordion/accordion.tsx | 2 +- app/soapbox/components/ui/banner/banner.tsx | 2 +- .../components/ui/button/useButtonStyles.ts | 2 +- app/soapbox/components/ui/card/card.tsx | 2 +- .../components/ui/checkbox/checkbox.tsx | 2 +- app/soapbox/components/ui/counter/counter.tsx | 2 +- .../ui/emoji-selector/emoji-selector.tsx | 71 ++- .../components/ui/form-group/form-group.tsx | 4 +- .../components/ui/icon-button/icon-button.tsx | 2 +- app/soapbox/components/ui/input/input.tsx | 2 +- app/soapbox/components/ui/menu/menu.tsx | 2 +- app/soapbox/components/ui/modal/modal.tsx | 4 +- .../ui/phone-input/country-code-dropdown.tsx | 2 +- .../ui/progress-bar/progress-bar.tsx | 4 +- .../ui/radio-button/radio-button.tsx | 2 +- app/soapbox/components/ui/select/select.tsx | 2 +- app/soapbox/components/ui/slider/slider.tsx | 6 +- app/soapbox/components/ui/tabs/tabs.tsx | 4 +- .../components/ui/tag-input/tag-input.tsx | 2 +- app/soapbox/components/ui/tag-input/tag.tsx | 2 +- app/soapbox/components/ui/toast/toast.tsx | 8 +- app/soapbox/components/upload-progress.tsx | 2 +- app/soapbox/components/verification-badge.tsx | 2 +- app/soapbox/containers/soapbox.tsx | 2 +- app/soapbox/features/about/index.tsx | 2 +- .../components/moved-note.tsx | 2 +- .../features/account/components/header.tsx | 2 +- .../features/admin/components/report.tsx | 2 +- app/soapbox/features/admin/user-index.tsx | 23 +- app/soapbox/features/ads/components/ad.tsx | 2 +- .../features/aliases/components/search.tsx | 2 +- app/soapbox/features/audio/index.tsx | 2 +- .../auth-login/components/consumers-list.tsx | 2 +- .../features/auth-token-list/index.tsx | 2 +- .../chats/components/chat-composer.tsx | 4 +- .../chats/components/chat-list-item.tsx | 4 +- .../features/chats/components/chat-list.tsx | 4 +- .../chats/components/chat-message-list.tsx | 4 +- .../chats/components/chat-page/chat-page.tsx | 6 +- .../chat-page/components/chat-page-main.tsx | 4 +- .../chats/components/chat-search/results.tsx | 4 +- .../chat-widget/chat-pane-header.tsx | 2 +- .../components/chat-widget/chat-settings.tsx | 4 +- .../features/chats/components/chat.tsx | 2 +- .../features/chats/components/ui/pane.tsx | 2 +- .../compose/components/privacy-dropdown.tsx | 5 +- .../compose/components/reply-indicator.tsx | 6 +- .../directory/components/account-card.tsx | 2 +- .../features/embedded-status/index.tsx | 2 +- .../features/event/event-information.tsx | 4 +- .../features/feed-filtering/feed-carousel.tsx | 10 +- .../feed-suggestions/feed-suggestions.tsx | 2 +- app/soapbox/features/forms/index.tsx | 57 --- .../group/components/group-header.tsx | 2 +- app/soapbox/features/home-timeline/index.tsx | 2 +- app/soapbox/features/landing-page/index.tsx | 2 +- app/soapbox/features/migration/index.tsx | 2 +- .../components/clear-column-button.tsx | 18 - .../notifications/components/notification.tsx | 2 +- .../steps/avatar-selection-step.tsx | 2 +- .../onboarding/steps/completed-step.tsx | 2 +- .../steps/cover-photo-selection-step.tsx | 4 +- .../onboarding/steps/fediverse-step.tsx | 4 +- .../steps/suggested-accounts-step.tsx | 2 +- .../components/placeholder-avatar.tsx | 4 +- .../components/placeholder-card.tsx | 2 +- .../components/placeholder-chat-message.tsx | 4 +- .../components/placeholder-display-name.tsx | 2 +- .../components/placeholder-event-header.tsx | 2 +- .../components/placeholder-event-preview.tsx | 4 +- .../components/placeholder-group-card.tsx | 6 +- .../components/placeholder-hashtag.tsx | 2 +- .../components/placeholder-media-gallery.tsx | 2 +- .../components/placeholder-notification.tsx | 2 +- .../placeholder-sidebar-suggestions.tsx | 2 +- .../components/placeholder-sidebar-trends.tsx | 2 +- .../components/placeholder-status-content.tsx | 2 +- .../public-layout/components/footer.tsx | 2 +- .../public-layout/components/sonar.tsx | 10 +- .../features/settings/media-display.tsx | 58 --- .../components/site-preview.tsx | 8 +- .../features/status/components/card.tsx | 6 +- app/soapbox/features/status/index.tsx | 4 +- .../ui/components/background-shapes.tsx | 2 +- .../ui/components/floating-action-button.tsx | 8 +- .../features/ui/components/link-footer.tsx | 2 +- .../ui/components/modals/actions-modal.tsx | 16 +- .../modals/compare-history-modal.tsx | 2 +- .../compose-event-modal.tsx | 2 +- .../compose-event-modal/upload-button.tsx | 2 +- .../ui/components/modals/hotkeys-modal.tsx | 2 +- .../components/modals/landing-page-modal.tsx | 2 +- .../manage-group-modal/steps/details-step.tsx | 8 +- .../ui/components/modals/policy-modal.tsx | 12 +- .../modals/report-modal/report-modal.tsx | 2 +- .../report-modal/steps/confirmation-step.tsx | 2 +- .../modals/report-modal/steps/reason-step.tsx | 6 +- .../components/modals/unauthorized-modal.tsx | 9 +- app/soapbox/features/ui/components/navbar.tsx | 4 +- .../ui/components/profile-info-panel.tsx | 2 +- app/soapbox/features/ui/index.tsx | 2 - .../features/ui/util/async-components.ts | 4 - .../features/verification/email-passthru.tsx | 8 +- .../features/verification/registration.tsx | 4 +- .../verification/steps/email-verification.tsx | 2 +- app/styles/_mixins.scss | 8 - app/styles/application.scss | 3 - app/styles/basics.scss | 12 +- app/styles/components/audio-player.scss | 40 +- app/styles/components/columns.scss | 50 -- app/styles/components/compose-form.scss | 25 +- app/styles/components/emoji-reacts.scss | 98 ---- app/styles/components/icon.scss | 40 -- app/styles/components/media-gallery.scss | 14 +- app/styles/components/modal.scss | 311 ++++++------- app/styles/components/react-toggle.scss | 2 +- app/styles/components/search.scss | 17 - app/styles/components/status.scss | 1 - app/styles/components/video-player.scss | 16 +- app/styles/forms.scss | 430 +----------------- app/styles/loading.scss | 12 +- app/styles/placeholder.scss | 40 -- app/styles/rtl.scss | 50 -- app/styles/themes.scss | 77 ---- app/styles/ui.scss | 12 +- app/styles/variables.scss | 16 - 147 files changed, 459 insertions(+), 1565 deletions(-) delete mode 100644 app/soapbox/features/notifications/components/clear-column-button.tsx delete mode 100644 app/soapbox/features/settings/media-display.tsx delete mode 100644 app/styles/components/emoji-reacts.scss delete mode 100644 app/styles/placeholder.scss delete mode 100644 app/styles/themes.scss diff --git a/.eslintrc.cjs b/.eslintrc.cjs index 51cc6e833..590653361 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -265,8 +265,11 @@ module.exports = { 'react-hooks/rules-of-hooks': 'error', - 'tailwindcss/classnames-order': 'error', + 'tailwindcss/classnames-order': ['error', { + callees: ['classNames'], + }], 'tailwindcss/migration-from-tailwind-2': 'error', + 'tailwindcss/no-custom-classname': 'off', }, overrides: [ { diff --git a/app/soapbox/components/account.tsx b/app/soapbox/components/account.tsx index 2901433ec..710737963 100644 --- a/app/soapbox/components/account.tsx +++ b/app/soapbox/components/account.tsx @@ -43,7 +43,7 @@ const InstanceFavicon: React.FC = ({ account, disabled }) => { return ( diff --git a/app/soapbox/components/autosuggest-input.tsx b/app/soapbox/components/autosuggest-input.tsx index 122890112..dcc2e78d7 100644 --- a/app/soapbox/components/autosuggest-input.tsx +++ b/app/soapbox/components/autosuggest-input.tsx @@ -235,7 +235,7 @@ export default class AutosuggestInput extends ImmutablePureComponent (