From 0679b446524e81b11db5705b1842735ad8a1ee14 Mon Sep 17 00:00:00 2001
From: Siddharth Singh <me@shantaram.xyz>
Date: Tue, 1 Apr 2025 13:52:25 +0530
Subject: [PATCH] little oopsie with the intl stuff

---
 src/features/admin/components/policies/Policy.tsx       | 7 ++++++-
 src/features/admin/components/policies/PolicyFields.tsx | 6 ++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/features/admin/components/policies/Policy.tsx b/src/features/admin/components/policies/Policy.tsx
index 35150d83a..f23b2d2e7 100644
--- a/src/features/admin/components/policies/Policy.tsx
+++ b/src/features/admin/components/policies/Policy.tsx
@@ -1,6 +1,6 @@
 import CloseIcon from '@tabler/icons/outline/x.svg';
 import { FC } from 'react';
-import { useIntl } from 'react-intl';
+import { defineMessages, useIntl } from 'react-intl';
 
 import { Card, CardHeader, CardBody } from 'soapbox/components/ui/card.tsx';
 import Icon from 'soapbox/components/ui/icon.tsx';
@@ -8,6 +8,10 @@ import { PolicySpecItem, PolicyItem, PolicyState, PolicyAction } from 'soapbox/u
 
 import { PolicyFields } from './PolicyFields.tsx';
 
+const messages = defineMessages({
+  removePolicy: { id: 'admin.policies.remove_policy', defaultMessage: 'Remove policy' },
+});
+
 export const Policy: FC<{
   policy: PolicySpecItem;
   registry: PolicyItem[];
@@ -30,6 +34,7 @@ export const Policy: FC<{
           <button
             onClick={handleRemovePolicy}
             className='ml-2 text-gray-500 hover:text-gray-100'
+            aria-label={intl.formatMessage(messages.removePolicy)}
           >
             <Icon src={CloseIcon} className='size-4' />
           </button>
diff --git a/src/features/admin/components/policies/PolicyFields.tsx b/src/features/admin/components/policies/PolicyFields.tsx
index a233b9509..bcb121505 100644
--- a/src/features/admin/components/policies/PolicyFields.tsx
+++ b/src/features/admin/components/policies/PolicyFields.tsx
@@ -16,11 +16,12 @@ const messages = defineMessages({
 const MultiValueBadge: FC<{
   value: string | number;
   onRemove: () => void;
-}> = ({ value, onRemove }) => {
+  intl: ReturnType<typeof useIntl>;
+}> = ({ value, onRemove, intl }) => {
   return (
     <div className='mb-2 mr-2 inline-flex items-center rounded-full bg-gray-200 px-2 py-1 text-gray-800'>
       <span className='mr-1 max-w-28 overflow-hidden text-ellipsis' title={String(value)}>{value}</span>
-      <button onClick={onRemove} className='text-gray-600 hover:text-gray-800' aria-label={messages.removeValue.defaultMessage}>
+      <button onClick={onRemove} className='text-gray-600 hover:text-gray-800' aria-label={intl.formatMessage(messages.removeValue)}>
         <Icon src={CloseIcon} className='size-4' />
       </button>
     </div>
@@ -115,6 +116,7 @@ export const PolicyFields: FC<{
           {((value || []) as (string | number)[]).map((v) => (
             <MultiValueBadge
               key={v}
+              intl={intl}
               value={v}
               onRemove={() => handleRemoveMultiValue(v)}
             />