From fb48c4cf0ec5adfab4172d4df608cd2f25092b29 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 18 Aug 2021 18:17:58 -0400 Subject: [PATCH] remove ref attr --- docs/resources/changelog.md | 1 + src/components/button/button.ts | 1 - src/components/icon-button/icon-button.ts | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md index 22a8d777..4f97580d 100644 --- a/docs/resources/changelog.md +++ b/docs/resources/changelog.md @@ -48,6 +48,7 @@ This change applies to all design tokens that implement a color. Refer to the [c - Exposed base and dark stylesheets so they can be imported via JavaScript [#438](https://github.com/shoelace-style/shoelace/issues/438) - Fixed a bug in `sl-menu` where pressing Enter after using type to select would result in the wrong value - Fixed a bug in `sl-radio-group` where clicking a radio button would cause the wrong control to be focused +- Fixed a bug in `sl-button` and `sl-icon-button` where an unintended `ref` attribute was present - Improved contrast throughout all components [#128](https://github.com/shoelace-style/shoelace/issues/128) - Refactored thumb position logic in `sl-switch` [#490](https://github.com/shoelace-style/shoelace/pull/490) - Reworked the dark theme to use an inverted token approach instead of light DOM selectors diff --git a/src/components/button/button.ts b/src/components/button/button.ts index 7e5f5bc0..622a704a 100644 --- a/src/components/button/button.ts +++ b/src/components/button/button.ts @@ -156,7 +156,6 @@ export default class SlButton extends LitElement { return isLink ? html` (this.button = el)} part="base" class=${classMap({ button: true, diff --git a/src/components/icon-button/icon-button.ts b/src/components/icon-button/icon-button.ts index a7c0ecf0..1f742990 100644 --- a/src/components/icon-button/icon-button.ts +++ b/src/components/icon-button/icon-button.ts @@ -73,7 +73,6 @@ export default class SlIconButton extends LitElement { return isLink ? html` (this.button = el)} part="base" class="icon-button" href=${ifDefined(this.href)}