From e60c5c4546d4d6b8c2ca5d9b2e00b48d369e726e Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Tue, 24 May 2022 08:12:13 -0400 Subject: [PATCH] update eslint --- .eslintrc.cjs | 28 ------------------- src/components/checkbox/checkbox.test.ts | 4 +-- src/components/icon/icon.test.ts | 8 +++--- .../radio-button/radio-button.test.ts | 6 ++-- src/components/radio/radio.test.ts | 6 ++-- src/components/switch/switch.test.ts | 8 +++--- 6 files changed, 16 insertions(+), 44 deletions(-) diff --git a/.eslintrc.cjs b/.eslintrc.cjs index ed018e18..12cb4734 100644 --- a/.eslintrc.cjs +++ b/.eslintrc.cjs @@ -83,34 +83,6 @@ module.exports = { '@typescript-eslint/consistent-type-definitions': ['warn', 'interface'], '@typescript-eslint/member-delimiter-style': 'warn', '@typescript-eslint/method-signature-style': 'warn', - '@typescript-eslint/naming-convention': [ - 'warn', - { - selector: 'default', - format: ['camelCase'] - }, - { - selector: ['function', 'enumMember', 'property'], - format: ['camelCase', 'PascalCase'] - }, - { - selector: 'variable', - modifiers: ['const'], - format: ['camelCase', 'PascalCase', 'UPPER_CASE'] - }, - { - selector: 'typeLike', - format: ['PascalCase'] - }, - { - selector: 'typeProperty', - format: ['camelCase', 'PascalCase', 'UPPER_CASE'] - }, - { - selector: 'objectLiteralProperty', - format: null - } - ], '@typescript-eslint/no-extraneous-class': 'error', '@typescript-eslint/no-parameter-properties': 'error', '@typescript-eslint/strict-boolean-expressions': 'off' diff --git a/src/components/checkbox/checkbox.test.ts b/src/components/checkbox/checkbox.test.ts index 027315d2..a1ae0a58 100644 --- a/src/components/checkbox/checkbox.test.ts +++ b/src/components/checkbox/checkbox.test.ts @@ -30,7 +30,7 @@ describe('', () => { it('should fire sl-change when clicked', async () => { const el = await fixture(html` `); setTimeout(() => el.shadowRoot!.querySelector('input')!.click()); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -40,7 +40,7 @@ describe('', () => { const input = el.shadowRoot!.querySelector('input')!; input.focus(); setTimeout(() => sendKeys({ press: ' ' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); diff --git a/src/components/icon/icon.test.ts b/src/components/icon/icon.test.ts index 57ba58c1..bf445030 100644 --- a/src/components/icon/icon.test.ts +++ b/src/components/icon/icon.test.ts @@ -46,7 +46,7 @@ describe('', () => { it('renders pre-loaded system icons and emits sl-load event', async () => { const el = await fixture(html` `); - const listener = oneEvent(el, 'sl-load'); + const listener = oneEvent(el, 'sl-load') as Promise; el.name = 'check-lg'; const ev = await listener; @@ -102,7 +102,7 @@ describe('', () => { describe('new library', () => { it('renders icons from the new library and emits sl-load event', async () => { const el = await fixture(html` `); - const listener = oneEvent(el, 'sl-load'); + const listener = oneEvent(el, 'sl-load') as Promise; el.name = 'test-icon1'; const ev = await listener; @@ -131,7 +131,7 @@ describe('', () => { it('emits sl-error when the file cant be retrieved', async () => { const el = await fixture(html` `); - const listener = oneEvent(el, 'sl-error'); + const listener = oneEvent(el, 'sl-error') as Promise; el.name = 'bad-request'; const ev = await listener; @@ -143,7 +143,7 @@ describe('', () => { it("emits sl-error when there isn't an svg element in the registered icon", async () => { const el = await fixture(html` `); - const listener = oneEvent(el, 'sl-error'); + const listener = oneEvent(el, 'sl-error') as Promise; el.name = 'bad-icon'; const ev = await listener; diff --git a/src/components/radio-button/radio-button.test.ts b/src/components/radio-button/radio-button.test.ts index 8b865e33..ef0f6d04 100644 --- a/src/components/radio-button/radio-button.test.ts +++ b/src/components/radio-button/radio-button.test.ts @@ -20,7 +20,7 @@ describe('', () => { it('should fire sl-change when clicked', async () => { const el = await fixture(html` `); setTimeout(() => el.input.click()); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -29,7 +29,7 @@ describe('', () => { const el = await fixture(html` `); el.input.focus(); setTimeout(() => sendKeys({ press: ' ' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -45,7 +45,7 @@ describe('', () => { const radio2 = radioGroup.querySelector('#radio-2')!; radio1.input.focus(); setTimeout(() => sendKeys({ press: 'ArrowRight' })); - const event = await oneEvent(radio2, 'sl-change'); + const event = (await oneEvent(radio2, 'sl-change')) as CustomEvent; expect(event.target).to.equal(radio2); expect(radio2.checked).to.be.true; }); diff --git a/src/components/radio/radio.test.ts b/src/components/radio/radio.test.ts index 7c625d30..9c866be4 100644 --- a/src/components/radio/radio.test.ts +++ b/src/components/radio/radio.test.ts @@ -21,7 +21,7 @@ describe('', () => { it('should fire sl-change when clicked', async () => { const el = await fixture(html` `); setTimeout(() => el.input.click()); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -30,7 +30,7 @@ describe('', () => { const el = await fixture(html` `); el.input.focus(); setTimeout(() => sendKeys({ press: ' ' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -46,7 +46,7 @@ describe('', () => { const radio2 = radioGroup.querySelector('#radio-2')!; radio1.input.focus(); setTimeout(() => sendKeys({ press: 'ArrowRight' })); - const event = await oneEvent(radio2, 'sl-change'); + const event = (await oneEvent(radio2, 'sl-change')) as CustomEvent; expect(event.target).to.equal(radio2); expect(radio2.checked).to.be.true; }); diff --git a/src/components/switch/switch.test.ts b/src/components/switch/switch.test.ts index 010e18f1..315906ab 100644 --- a/src/components/switch/switch.test.ts +++ b/src/components/switch/switch.test.ts @@ -19,7 +19,7 @@ describe('', () => { it('should fire sl-change when clicked', async () => { const el = await fixture(html` `); setTimeout(() => el.shadowRoot!.querySelector('input')!.click()); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -28,7 +28,7 @@ describe('', () => { const el = await fixture(html` `); el.focus(); setTimeout(() => sendKeys({ press: ' ' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -37,7 +37,7 @@ describe('', () => { const el = await fixture(html` `); el.focus(); setTimeout(() => sendKeys({ press: 'ArrowRight' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.true; }); @@ -46,7 +46,7 @@ describe('', () => { const el = await fixture(html` `); el.focus(); setTimeout(() => sendKeys({ press: 'ArrowLeft' })); - const event = await oneEvent(el, 'sl-change'); + const event = (await oneEvent(el, 'sl-change')) as CustomEvent; expect(event.target).to.equal(el); expect(el.checked).to.be.false; });