don't block escape; fixes #1607

pull/1661/head
Cory LaViska 2023-10-18 13:42:03 -04:00
rodzic afe7778f89
commit a03ec4c14b
2 zmienionych plików z 2 dodań i 1 usunięć

Wyświetl plik

@ -15,6 +15,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
## Next
- Added the Croatian translation [#1656]
- Fixed a bug that caused the [[Escape]] key to stop propagating when tooltips are disabled [#1607]
## 2.10.0

Wyświetl plik

@ -145,7 +145,7 @@ export default class SlTooltip extends ShoelaceElement {
private handleKeyDown = (event: KeyboardEvent) => {
// Pressing escape when the target element has focus should dismiss the tooltip
if (this.open && event.key === 'Escape') {
if (this.open && !this.disabled && event.key === 'Escape') {
event.stopPropagation();
this.hide();
}