From 298892b10a1cc42536d2e6f2b08e5912c029833e Mon Sep 17 00:00:00 2001 From: cyantree Date: Wed, 21 Feb 2024 00:27:32 +0100 Subject: [PATCH] fix race condition in `submenu-controller` (#1815) --- src/components/menu-item/submenu-controller.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/menu-item/submenu-controller.ts b/src/components/menu-item/submenu-controller.ts index 67b0ee35..3d03b07d 100644 --- a/src/components/menu-item/submenu-controller.ts +++ b/src/components/menu-item/submenu-controller.ts @@ -229,6 +229,7 @@ export class SubmenuController implements ReactiveController { // newly opened menu. private enableSubmenu(delay = true) { if (delay) { + window.clearTimeout(this.enableSubmenuTimer); this.enableSubmenuTimer = window.setTimeout(() => { this.setSubmenuState(true); }, this.submenuOpenDelay); @@ -238,7 +239,7 @@ export class SubmenuController implements ReactiveController { } private disableSubmenu() { - clearTimeout(this.enableSubmenuTimer); + window.clearTimeout(this.enableSubmenuTimer); this.setSubmenuState(false); }