fix boolean true prop

pull/478/head
Cory LaViska 2021-07-01 17:23:16 -04:00
rodzic 10cd4b8999
commit 6fd5a97fde
3 zmienionych plików z 9 dodań i 5 usunięć

Wyświetl plik

@ -14,6 +14,7 @@ This is a lot more intuitive and makes it easier to activate animations imperati
- 🚨 BREAKING: removed the `pause` prop from `sl-animation` (use the `play` prop to start and stop the animation instead)
- 🚨 BREAKING: removed `getCurrentTime()` and `setCurrentTime()` from `sl-animation` (use the `currentTime` property instead)
- 🚨 BREAKING: removed `closeOnSelect` prop from `sl-dropdown` (use `stayOpenOnSelect` instead)
- Added `currentTime` to `sl-animation` to control the current time without methods
## 2.0.0-beta.45

Wyświetl plik

@ -25,7 +25,7 @@ let id = 0;
* @event sl-show - Emitted when the dropdown opens.
* @event sl-after-show - Emitted after the dropdown opens and all animations are complete.
* @event sl-hide - Emitted when the dropdown closes.
* @event sl-after-hide - Emitted after the dropdown closes and all animations are complete.*
* @event sl-after-hide - Emitted after the dropdown closes and all animations are complete.
*
* @csspart base - The component's base wrapper.
* @csspart trigger - The container that wraps the trigger.
@ -69,8 +69,11 @@ export default class SlDropdown extends LitElement {
/** Disables the dropdown so the panel will not open. */
@property({ type: Boolean }) disabled = false;
/** Determines whether the dropdown should hide when a menu item is selected. */
@property({ attribute: 'close-on-select', type: Boolean, reflect: true }) closeOnSelect = true;
/**
* By default, the dropdown is closed when an item is selected. This attribute will keep it open instead. Useful for
* controls that allow multiple selections.
*/
@property({ attribute: 'stay-open-on-select', type: Boolean, reflect: true }) stayOpenOnSelect = false;
/** The dropdown will close when the user interacts outside of this element (e.g. clicking). */
@property({ attribute: false }) containingElement: HTMLElement;
@ -198,7 +201,7 @@ export default class SlDropdown extends LitElement {
const target = event.target as HTMLElement;
// Hide the dropdown when a menu item is selected
if (this.closeOnSelect && target.tagName.toLowerCase() === 'sl-menu') {
if (!this.stayOpenOnSelect && target.tagName.toLowerCase() === 'sl-menu') {
this.hide();
this.focusOnTrigger();
}

Wyświetl plik

@ -415,7 +415,7 @@ export default class SlSelect extends LitElement {
<sl-dropdown
part="base"
.hoist=${this.hoist}
.closeOnSelect=${!this.multiple}
.stayOpenOnSelect=${this.multiple}
.containingElement=${this}
?disabled=${this.disabled}
class=${classMap({