From 4e09bacae942e76a687b1339b4624b12cadc6f68 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Fri, 4 Oct 2024 16:24:27 -0400 Subject: [PATCH] fix select padding; fixes #2194 (#2197) --- docs/pages/resources/changelog.md | 1 + src/components/select/select.styles.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md index 66eac0eb..f32ed0d7 100644 --- a/docs/pages/resources/changelog.md +++ b/docs/pages/resources/changelog.md @@ -16,6 +16,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti - Fixed a bug in `` causing scroll jumping when using `resize="auto"` [#2182] - Fixed a bug in `` where the title attribute would show with redundant info [#2184] +- Fixed a bug in `` that caused multi-selects without placeholders to have the wrong padding [#2194] ## 2.17.1 diff --git a/src/components/select/select.styles.ts b/src/components/select/select.styles.ts index 16d1a12c..224360b9 100644 --- a/src/components/select/select.styles.ts +++ b/src/components/select/select.styles.ts @@ -209,7 +209,7 @@ export default css` margin-inline-start: var(--sl-input-spacing-medium); } - .select--medium.select--multiple:not(.select--placeholder-visible) .select__combobox { + .select--medium.select--multiple .select__combobox { padding-inline-start: 0; padding-block: 3px; } @@ -238,7 +238,7 @@ export default css` margin-inline-start: var(--sl-input-spacing-large); } - .select--large.select--multiple:not(.select--placeholder-visible) .select__combobox { + .select--large.select--multiple .select__combobox { padding-inline-start: 0; padding-block: 4px; }