From 4a0f6ef8af0411e8326b72247760e75d56e5279f Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Mon, 2 May 2022 16:33:30 -0400 Subject: [PATCH] reflect disabled in dropdown --- docs/resources/changelog.md | 1 + src/components/dropdown/dropdown.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md index e8dc3158..034f2c7a 100644 --- a/docs/resources/changelog.md +++ b/docs/resources/changelog.md @@ -13,6 +13,7 @@ _During the beta period, these restrictions may be relaxed in the event of a mis - Fixed a bug where updating a menu item's label wouldn't update the display label in `` [#729](https://github.com/shoelace-style/shoelace/issues/729) - Improved performance of `` by caching menu items instead of traversing for them each time - Revert form submit logic [#718](https://github.com/shoelace-style/shoelace/issues/718) +- Updated the `disabled` attribute so it reflects in `` [#741](https://github.com/shoelace-style/shoelace/discussions/741) - Updated the `name` and `icon` attribute so they reflect in `` [#742](https://github.com/shoelace-style/shoelace/pull/742) ## 2.0.0-beta.73 diff --git a/src/components/dropdown/dropdown.ts b/src/components/dropdown/dropdown.ts index 16e463fb..2d5d939c 100644 --- a/src/components/dropdown/dropdown.ts +++ b/src/components/dropdown/dropdown.ts @@ -65,7 +65,7 @@ export default class SlDropdown extends LitElement { | 'left-end' = 'bottom-start'; /** Disables the dropdown so the panel will not open. */ - @property({ type: Boolean }) disabled = false; + @property({ type: Boolean, reflect: true }) disabled = false; /** * By default, the dropdown is closed when an item is selected. This attribute will keep it open instead. Useful for