diff --git a/cspell.json b/cspell.json index 5a76ee66..fd909b93 100644 --- a/cspell.json +++ b/cspell.json @@ -53,6 +53,7 @@ "FOUC", "FOUCE", "fullscreen", + "gestern", "giga", "globby", "Grayscale", @@ -121,6 +122,7 @@ "tabpanel", "templating", "tera", + "testid", "textareas", "textfield", "tinycolor", diff --git a/docs/getting-started/usage.md b/docs/getting-started/usage.md index c990d974..adb47678 100644 --- a/docs/getting-started/usage.md +++ b/docs/getting-started/usage.md @@ -164,7 +164,7 @@ checkbox.checked = true; console.log(checkbox.hasAttribute('checked')); // false ``` -Most devs will expect this to be `true` instead of `false`, but the component hasn't had a chance to re-render yet so the attribute doesn't exist when `hasAttribute()` is called. Since changes are batched, we need to wait for the update before proceeding. This can be done using the `updateComplete` property, which is available on all Lit-based components. +Most developers will expect this to be `true` instead of `false`, but the component hasn't had a chance to re-render yet so the attribute doesn't exist when `hasAttribute()` is called. Since changes are batched, we need to wait for the update before proceeding. This can be done using the `updateComplete` property, which is available on all Lit-based components. ```js const checkbox = document.querySelector('sl-checkbox'); diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md index 851eef37..5d6387e7 100644 --- a/docs/resources/changelog.md +++ b/docs/resources/changelog.md @@ -281,8 +281,7 @@ This release removes the `` component. When this component - Fixed a bug in `` that prevented the keyboard from working when the component was nested in a shadow root [#871](https://github.com/shoelace-style/shoelace/issues/871) - Fixed a bug in `` that prevented the keyboard from working when the component was nested in a shadow root [#872](https://github.com/shoelace-style/shoelace/issues/872) - Fixed a bug in `` that allowed disabled tabs to erroneously receive focus -- Improved single selection in `` so nodes expand and collapse and rece - ive selection when clicking on the label +- Improved single selection in `` so nodes expand and collapse and receive selection when clicking on the label - Renamed `expanded-icon` and `collapsed-icon` slots to `expand-icon` and `collapse-icon` in the experimental `` and `` components - Improved RTL support for `` - Refactored components to extend from `ShoelaceElement` to make `dir` and `lang` reactive properties in all components diff --git a/src/components/input/input.test.ts b/src/components/input/input.test.ts index c72840aa..879b0089 100644 --- a/src/components/input/input.test.ts +++ b/src/components/input/input.test.ts @@ -350,7 +350,7 @@ describe('', () => { await el.updateComplete; }); - it('should not emit sl-change or sl-input when calling setinputText()', async () => { + it('should not emit sl-change or sl-input when calling setRangeText()', async () => { const el = await fixture(html` `); el.addEventListener('sl-change', () => expect.fail('sl-change should not be emitted'));