From 0b4dc3f6a81a66cf53042853255d50c765683267 Mon Sep 17 00:00:00 2001
From: Cory LaViska <cory@abeautifulsite.net>
Date: Wed, 7 Apr 2021 10:01:31 -0400
Subject: [PATCH] fixes #401
---
docs/resources/changelog.md | 1 +
src/components/color-picker/color-picker.ts | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md
index da822d4f..f835729d 100644
--- a/docs/resources/changelog.md
+++ b/docs/resources/changelog.md
@@ -13,6 +13,7 @@ _During the beta period, these restrictions may be relaxed in the event of a mis
- Fixed a bug in `sl-tooltip` where events weren't properly cleaned up on disconnect
- Fixed a bug in `sl-tooltip` where they wouldn't display after toggling `disabled` off and on again [#391](https://github.com/shoelace-style/shoelace/issues/391)
- Fixed a bug in `sl-details` where `show()` and `hide()` would toggle the control when disabled
+- Fixed a bug in `sl-color-picker` where setting `value` wouldn't update the control
- Fixed incorrect event names for `sl-after-show` and `sl-after-hide` in `sl-details`
- Improved a11y for disabled buttons that are rendered as links
- Improved a11y for `sl-button-group` by adding the correct `role` attribute
diff --git a/src/components/color-picker/color-picker.ts b/src/components/color-picker/color-picker.ts
index a3efcc13..ee83fd8b 100644
--- a/src/components/color-picker/color-picker.ts
+++ b/src/components/color-picker/color-picker.ts
@@ -570,7 +570,7 @@ export default class SlColorPicker extends LitElement {
}
@watch('value')
- handleValueChange(newValue: string, oldValue: string) {
+ handleValueChange(oldValue: string, newValue: string) {
if (!this.bypassValueParse) {
const newColor = this.parseColor(newValue);