kopia lustrzana https://gitlab.com/sane-project/website
106 wiersze
4.3 KiB
HTML
106 wiersze
4.3 KiB
HTML
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"
|
|
"http://www.w3.org/TR/REC-html40/loose.dtd">
|
|
<HTML>
|
|
<HEAD>
|
|
<TITLE>sane-devel: Re: bug in sanei_debug.h</TITLE>
|
|
<META NAME="Author" CONTENT="Petter Reinholdtsen (pere@hungry.com)">
|
|
<META NAME="Subject" CONTENT="Re: bug in sanei_debug.h">
|
|
</HEAD>
|
|
<BODY BGCOLOR="#FFFFFF" TEXT="#000000">
|
|
<H1>Re: bug in sanei_debug.h</H1>
|
|
<!-- received="Sun Oct 22 08:40:58 2000" -->
|
|
<!-- isoreceived="20001022154058" -->
|
|
<!-- sent="Sun, 22 Oct 2000 23:54:26 +0800" -->
|
|
<!-- isosent="20001022155426" -->
|
|
<!-- name="Petter Reinholdtsen" -->
|
|
<!-- email="pere@hungry.com" -->
|
|
<!-- subject="Re: bug in sanei_debug.h" -->
|
|
<!-- id="200010221554.XAA02379@localhost.localdomain" -->
|
|
<!-- inreplyto="bug in sanei_debug.h" -->
|
|
<STRONG>From:</STRONG> Petter Reinholdtsen (<A HREF="mailto:pere@hungry.com?Subject=Re:%20bug%20in%20sanei_debug.h&In-Reply-To=<200010221554.XAA02379@localhost.localdomain>"><EM>pere@hungry.com</EM></A>)<BR>
|
|
<STRONG>Date:</STRONG> Sun Oct 22 2000 - 08:54:26 PDT
|
|
<P>
|
|
<!-- next="start" -->
|
|
<LI><STRONG>Next message:</STRONG> <A HREF="0245.html">Petter Reinholdtsen: "Re: make dll.c robust against it being listed in its configuration file..."</A>
|
|
<UL>
|
|
<LI><STRONG>Previous message:</STRONG> <A HREF="0243.html">Petter Reinholdtsen: "Re: sane fronten packages"</A>
|
|
<LI><STRONG>Maybe in reply to:</STRONG> <A HREF="0142.html">Jochen Eisinger: "bug in sanei_debug.h"</A>
|
|
<!-- nextthread="start" -->
|
|
<LI><STRONG>Next in thread:</STRONG> <A HREF="0251.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<LI><STRONG>Reply:</STRONG> <A HREF="0251.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<!-- reply="end" -->
|
|
<LI><STRONG>Messages sorted by:</STRONG>
|
|
<A HREF="date.html#244">[ date ]</A>
|
|
<A HREF="index.html#244">[ thread ]</A>
|
|
<A HREF="subject.html#244">[ subject ]</A>
|
|
<A HREF="author.html#244">[ author ]</A>
|
|
</UL>
|
|
<HR NOSHADE><P>
|
|
<!-- body="start" -->
|
|
<P>
|
|
[Jochen Eisinger]
|
|
<BR>
|
|
<EM>> + msg = (char *)malloc (sizeof(char) * (strlen(be) + strlen(fmt) + 4));
|
|
</EM><BR>
|
|
<EM>> + if (msg == NULL)
|
|
</EM><BR>
|
|
<EM>> + {
|
|
</EM><BR>
|
|
<EM>> + vsyslog (LOG_DEBUG, fmt, ap);
|
|
</EM><BR>
|
|
<EM>> + }
|
|
</EM><BR>
|
|
<P>Eh, don't you think a failing malloc() should be logged as well? I
|
|
<BR>
|
|
guess out of memory problems will give lots of errors elsewhere in the
|
|
<BR>
|
|
code, and it would be nice for the person trying to find the problem
|
|
<BR>
|
|
to know what is happending. I suggest logging a message like
|
|
<BR>
|
|
'[sanei_debug] malloc() failed' when this happending, in addition to
|
|
<BR>
|
|
the message itself.
|
|
<BR>
|
|
<P>Other then this, I liked the suggested change. Go ahead and commit
|
|
<BR>
|
|
it. :-)
|
|
<BR>
|
|
<P>Is this the last GCC extention used in the code? I hope so. :-)
|
|
<BR>
|
|
<PRE>
|
|
--
|
|
##> Petter Reinholdtsen <## | <A HREF="mailto:pere@td.org.uit.no?Subject=Re:%20bug%20in%20sanei_debug.h&In-Reply-To=<200010221554.XAA02379@localhost.localdomain>">pere@td.org.uit.no</A>
|
|
<P>--
|
|
Source code, list archive, and docs: <A HREF="http://www.mostang.com/sane/">http://www.mostang.com/sane/</A>
|
|
To unsubscribe: echo unsubscribe sane-devel | mail <A HREF="mailto:majordomo@mostang.com?Subject=Re:%20bug%20in%20sanei_debug.h&In-Reply-To=<200010221554.XAA02379@localhost.localdomain>">majordomo@mostang.com</A>
|
|
</PRE>
|
|
<P><!-- body="end" -->
|
|
<HR NOSHADE>
|
|
<UL>
|
|
<!-- next="start" -->
|
|
<LI><STRONG>Next message:</STRONG> <A HREF="0245.html">Petter Reinholdtsen: "Re: make dll.c robust against it being listed in its configuration file..."</A>
|
|
<LI><STRONG>Previous message:</STRONG> <A HREF="0243.html">Petter Reinholdtsen: "Re: sane fronten packages"</A>
|
|
<LI><STRONG>Maybe in reply to:</STRONG> <A HREF="0142.html">Jochen Eisinger: "bug in sanei_debug.h"</A>
|
|
<!-- nextthread="start" -->
|
|
<LI><STRONG>Next in thread:</STRONG> <A HREF="0251.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<LI><STRONG>Reply:</STRONG> <A HREF="0251.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<!-- reply="end" -->
|
|
<LI><STRONG>Messages sorted by:</STRONG>
|
|
<A HREF="date.html#244">[ date ]</A>
|
|
<A HREF="index.html#244">[ thread ]</A>
|
|
<A HREF="subject.html#244">[ subject ]</A>
|
|
<A HREF="author.html#244">[ author ]</A>
|
|
</UL>
|
|
<!-- trailer="footer" -->
|
|
<HR NOSHADE>
|
|
<P>
|
|
<SMALL>
|
|
<EM>
|
|
This archive was generated by <A HREF="http://www.hypermail.org/">hypermail 2b29</A>
|
|
: <EM>Sun Oct 22 2000 - 08:41:24 PDT</EM>
|
|
</EM>
|
|
</SMALL>
|
|
</BODY>
|
|
</HTML>
|