kopia lustrzana https://gitlab.com/sane-project/website
136 wiersze
4.7 KiB
HTML
136 wiersze
4.7 KiB
HTML
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"
|
|
"http://www.w3.org/TR/REC-html40/loose.dtd">
|
|
<HTML>
|
|
<HEAD>
|
|
<TITLE>sane-devel: Re: bug in sanei_debug.h</TITLE>
|
|
<META NAME="Author" CONTENT="Jochen Eisinger (jochen.eisinger@gno.de)">
|
|
<META NAME="Subject" CONTENT="Re: bug in sanei_debug.h">
|
|
</HEAD>
|
|
<BODY BGCOLOR="#FFFFFF" TEXT="#000000">
|
|
<H1>Re: bug in sanei_debug.h</H1>
|
|
<!-- received="Tue Oct 17 09:40:38 2000" -->
|
|
<!-- isoreceived="20001017164038" -->
|
|
<!-- sent="Tue, 17 Oct 2000 18:31:06 +0200" -->
|
|
<!-- isosent="20001017163106" -->
|
|
<!-- name="Jochen Eisinger" -->
|
|
<!-- email="jochen.eisinger@gno.de" -->
|
|
<!-- subject="Re: bug in sanei_debug.h" -->
|
|
<!-- id="39EC7ECA.DD176E9A@gno.de" -->
|
|
<!-- inreplyto="200010171012.SAA04801@localhost.localdomain" -->
|
|
<STRONG>From:</STRONG> Jochen Eisinger (<A HREF="mailto:jochen.eisinger@gno.de?Subject=Re:%20bug%20in%20sanei_debug.h&In-Reply-To=<39EC7ECA.DD176E9A@gno.de>"><EM>jochen.eisinger@gno.de</EM></A>)<BR>
|
|
<STRONG>Date:</STRONG> Tue Oct 17 2000 - 09:31:06 PDT
|
|
<P>
|
|
<!-- next="start" -->
|
|
<LI><STRONG>Next message:</STRONG> <A HREF="0184.html">Denny Schanze: "Re:access denied"</A>
|
|
<UL>
|
|
<LI><STRONG>Previous message:</STRONG> <A HREF="0182.html">Oliver Rauch: "Re: Problems with saned/net backend"</A>
|
|
<LI><STRONG>In reply to:</STRONG> <A HREF="0179.html">Petter Reinholdtsen: "Re: bug in sanei_debug.h"</A>
|
|
<!-- nextthread="start" -->
|
|
<LI><STRONG>Next in thread:</STRONG> <A HREF="0189.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<LI><STRONG>Reply:</STRONG> <A HREF="0189.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<!-- reply="end" -->
|
|
<LI><STRONG>Messages sorted by:</STRONG>
|
|
<A HREF="date.html#183">[ date ]</A>
|
|
<A HREF="index.html#183">[ thread ]</A>
|
|
<A HREF="subject.html#183">[ subject ]</A>
|
|
<A HREF="author.html#183">[ author ]</A>
|
|
</UL>
|
|
<HR NOSHADE><P>
|
|
<!-- body="start" -->
|
|
<P>
|
|
Hi!
|
|
<BR>
|
|
<P>[Petter Reinholdtsen]
|
|
<BR>
|
|
<EM>> I suggest removing the vararg macro implementation if the new one
|
|
</EM><BR>
|
|
<EM>> works equally well. It would be very nice to have portable code in
|
|
</EM><BR>
|
|
<EM>> the debug functions.
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> > * debug_msg is no more static (maybe it should be renamed
|
|
</EM><BR>
|
|
<EM>> > sanei_debug_msg to avoid conflicts)
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> Good idea.
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> > * it allocates memory
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> This can be avoided by changing the arguments to debug_msg() to
|
|
</EM><BR>
|
|
<EM>> inclued the backend name as well:
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> debug_msg (level, DBG_LEVEL, STRINGIFY(BACKEND_NAME), msg, ap);
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> Then the output can be printed with two vfprintf() calls unless stderr
|
|
</EM><BR>
|
|
<EM>> is a socket. If it is a socket, I guess there is no other way to make
|
|
</EM><BR>
|
|
<EM>> sure all the info is included in the syslog message but to allocate
|
|
</EM><BR>
|
|
<EM>> some memory. :-/
|
|
</EM><BR>
|
|
<EM>>
|
|
</EM><BR>
|
|
<EM>> Why did you not make the DBG_LOCAL function static? I believe it
|
|
</EM><BR>
|
|
<EM>> should be.
|
|
</EM><BR>
|
|
Ok, I've implemented all this what you've suggested... the patch
|
|
<BR>
|
|
compiles fine on my machine
|
|
<BR>
|
|
<P>-- jochen
|
|
<BR>
|
|
|
|
<BR><HR NOSHADE>
|
|
<UL>
|
|
<LI>application/x-gzip attachment: <A HREF="att-0183/01-sanei_debug.patch.tar.gz">sanei_debug.patch.tar.gz</A>
|
|
</UL>
|
|
<!-- attachment="01-sanei_debug.patch.tar.gz" -->
|
|
<P><P><PRE>
|
|
--
|
|
Source code, list archive, and docs: <A HREF="http://www.mostang.com/sane/">http://www.mostang.com/sane/</A>
|
|
To unsubscribe: echo unsubscribe sane-devel | mail <A HREF="mailto:majordomo@mostang.com?Subject=Re:%20bug%20in%20sanei_debug.h&In-Reply-To=<39EC7ECA.DD176E9A@gno.de>">majordomo@mostang.com</A>
|
|
</PRE>
|
|
<P><!-- body="end" -->
|
|
<HR NOSHADE>
|
|
<UL>
|
|
<!-- next="start" -->
|
|
<LI><STRONG>Next message:</STRONG> <A HREF="0184.html">Denny Schanze: "Re:access denied"</A>
|
|
<LI><STRONG>Previous message:</STRONG> <A HREF="0182.html">Oliver Rauch: "Re: Problems with saned/net backend"</A>
|
|
<LI><STRONG>In reply to:</STRONG> <A HREF="0179.html">Petter Reinholdtsen: "Re: bug in sanei_debug.h"</A>
|
|
<!-- nextthread="start" -->
|
|
<LI><STRONG>Next in thread:</STRONG> <A HREF="0189.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<LI><STRONG>Reply:</STRONG> <A HREF="0189.html">Jochen Eisinger: "Re: bug in sanei_debug.h"</A>
|
|
<!-- reply="end" -->
|
|
<LI><STRONG>Messages sorted by:</STRONG>
|
|
<A HREF="date.html#183">[ date ]</A>
|
|
<A HREF="index.html#183">[ thread ]</A>
|
|
<A HREF="subject.html#183">[ subject ]</A>
|
|
<A HREF="author.html#183">[ author ]</A>
|
|
</UL>
|
|
<!-- trailer="footer" -->
|
|
<HR NOSHADE>
|
|
<P>
|
|
<SMALL>
|
|
<EM>
|
|
This archive was generated by <A HREF="http://www.hypermail.org/">hypermail 2b29</A>
|
|
: <EM>Tue Oct 17 2000 - 09:46:36 PDT</EM>
|
|
</EM>
|
|
</SMALL>
|
|
</BODY>
|
|
</HTML>
|