The readdir_r() using loop in sanei_scsi_find_devices() has been
modified to use readdir().
With the exception of sane_cancel(), the SANE API is not re-entrant.
The sanei_scsi_find_devices() function is referenced neither directly
nor indirectly from any of the sane_cancel() implementations so there
is no inherent need to use readdir_r().
The warning reads:
enumerator value for '_PS_INP_MIO6' is not an integer constant
expression
and that comes about as _PS_INP_MIO6 evaluates to 0x8000000, which
does not fit in the *signed* integer range which has been allotted
to enumeration constants by ISO C99.
Seeing that the _PS_INP* values appear to be bitflags (despite the
arithmatic additions in backend/plustek-usbdev.c!) it is safer to
use #defines instead of an enum.
The indentation has been aligned what is used inside the while loop.
The function appears to have been copied from elsewhere and slightly
modified.
The msg variable is set to NULL inside the if branch for efficiency
only.
The u8_range and threshold_percentage_range constants have not been
used for anything ever since the backend's addition. They probable
ended up in the code as a result of copy-and-paste.
The const variables' definition has been #ifdef'd to prevent loss of
protocol info.
Neither scsi_area_and_windows nor scsi_lookup_table appear to have
been used for anything.
The s8_range variable appears to be a left-over from the epson
backend's "fork" and became superfluous after refactoring the
colour correction support in the epson2 backend.
The percentage_range hasn't been used for anything since the initial
revision of the file.
This also gets rid of a [-Wshift-negative-value] warning as well as a
"initializer element is not a constant expression" pedantic warning.
This:
- modifies `configure.ac` to get a version number courtesy of `git`
when `autoconf` is run
- runs a `make dist` when all compilation targets succeed
- makes the resulting tarball available as a build artifact
- renames the various pipeline stages
There is no need to depend on and link in all the various dependencies
for whatever backends *might* be preloaded if none are. Distributions
habitually rip these out, rightfully so, to reduce the list of package
dependencies. This will achieve the same while still doing the "right
thing" for builds that do preload one or more backens.
When generating lists of files with `find`, directories may get output
if you try to prune paths and it has a habit of prefixing paths with a
leading `./`.
The various checks cover all settings in the `.editorconfig` file.
The `--fix` support, however, does not attempt to correct charset
issues because the encoding cannot be determined automatically.
Note that image files as well as generated files in the repository
are exempted from all style checks.
Changes to the test reference files should not, famous last words ;-),
have any effect on the use of the tool's actual outputs.
Note that the tests use a "concocted" `testfile.desc` as their input.
Rolf Bensch