From efd59b15356b1f161e0fc369c00b14ccfd4ced77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Voltz?= <stef.dev@free.fr>
Date: Wed, 15 Sep 2010 06:13:50 +0200
Subject: [PATCH] valgrind memory leaks/overwrite fixes

---
 backend/genesys.c   | 19 +++++++++++--------
 sanei/sanei_magic.c |  2 +-
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/backend/genesys.c b/backend/genesys.c
index b5fcc7dd8..f01bb6bb6 100644
--- a/backend/genesys.c
+++ b/backend/genesys.c
@@ -3128,15 +3128,19 @@ compute_gl843_coefficients (Genesys_Device * dev,
   darkptr = (uint16_t *) dev->dark_average_data;
   whiteptr = (uint16_t *) dev->white_average_data;
 
-  size = pixels * 2 * 3 * 256 / 252 * 2 + 512;
-  free (buffer);
-  buffer = (unsigned short *) malloc (size);
-  if (buffer == NULL)
+  size = (pixels * 2 * 3 * 256) / 252 * 2 + 512;
+  DBG (DBG_io, "%s: final shading size=%04x\n", __FUNCTION__, size);
+  *shading_data = (unsigned short *) malloc (size);
+  if (*shading_data == NULL)
     return 0;
 
+  memset(*shading_data,0,size);
+
   /* offset */
-  buffer = buffer + 12;
-  count = 12;
+  buffer = *shading_data;
+  count = 0;
+
+  /* loop over calibration data to build shading coefficients */
   for (i = 0; i < pixels; i++)
     {
       /* red */
@@ -3529,9 +3533,8 @@ genesys_send_shading_coefficient (Genesys_Device * dev)
                             target_code);
       break;
     case CCD_KVSS080:
-      words_per_color=pixels_per_line * 2;
-      length = words_per_color * 3 * 2;
       target_code = 0xe000;
+      free(shading_data);
       length=compute_gl843_coefficients (dev,
 			                 &shading_data,
 			                 pixels_per_line,
diff --git a/sanei/sanei_magic.c b/sanei/sanei_magic.c
index e8daf50e8..3ec174900 100644
--- a/sanei/sanei_magic.c
+++ b/sanei/sanei_magic.c
@@ -1020,7 +1020,7 @@ getLine (int height, int width, int * buff,
 
   /* dont forget to cleanup */
   cleanup:
-  for(i=0;i<10;i++){
+  for(i=0;i<slopes;i++){
     if(lines[i])
       free(lines[i]);
   }