From a993e6438eff1e5b71f1dcc97df478ca954aae9f Mon Sep 17 00:00:00 2001 From: Olaf Meeuwissen Date: Sun, 22 Dec 2019 16:05:51 +0900 Subject: [PATCH] dll: Fix [-Wformat-truncation=] compiler warning Per POSIX, `readdir` returns filenames that are at most `NAME_MAX` long. --- backend/dll.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/backend/dll.c b/backend/dll.c index 926a08064..c88818c4f 100644 --- a/backend/dll.c +++ b/backend/dll.c @@ -799,7 +799,8 @@ read_dlld (void) DIR *dlld; struct dirent *dllconf; struct stat st; - char conffile[PATH_MAX], dlldir[PATH_MAX]; + char dlldir[PATH_MAX]; + char conffile[PATH_MAX + strlen("/") + NAME_MAX]; size_t len, plen; const char *dir_list; char *copy, *next, *dir; @@ -851,7 +852,7 @@ read_dlld (void) || (dllconf->d_name[len-1] == '#')) continue; - snprintf (conffile, PATH_MAX, "%s/%s", dlldir, dllconf->d_name); + snprintf (conffile, sizeof(conffile), "%s/%s", dlldir, dllconf->d_name); DBG (5, "sane_init/read_dlld: considering %s\n", conffile);