From 3282c5a65410055c7047d5642cc95da07ca50722 Mon Sep 17 00:00:00 2001
From: Povilas Kanapickas <povilas@radix.lt>
Date: Tue, 26 May 2020 01:13:18 +0300
Subject: [PATCH 1/3] genesys: Fix TIFF file writing

---
 backend/genesys/image.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/backend/genesys/image.cpp b/backend/genesys/image.cpp
index c3ada333f..793a209df 100644
--- a/backend/genesys/image.cpp
+++ b/backend/genesys/image.cpp
@@ -233,7 +233,7 @@ void write_tiff_file(const std::string& filename, const void* data, int depth, i
 
     // we don't need to handle endian because libtiff will handle that
     for (int iline = 0; iline < lines; ++iline) {
-        const auto* line_data = data_ptr + bytes_per_line;
+        const auto* line_data = data_ptr + bytes_per_line * iline;
         TIFFWriteScanline(image, const_cast<std::uint8_t*>(line_data), iline, 0);
     }
     TIFFClose(image);

From c9182dc6067279cf3cb153d97f5a5105d1a35308 Mon Sep 17 00:00:00 2001
From: Povilas Kanapickas <povilas@radix.lt>
Date: Tue, 26 May 2020 01:13:19 +0300
Subject: [PATCH 2/3] genesys: Ensure ImagePipelineStack nodes are destroyed in
 reverse order

---
 backend/genesys/image_pipeline.h | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/backend/genesys/image_pipeline.h b/backend/genesys/image_pipeline.h
index 39f6398c6..0e3264a72 100644
--- a/backend/genesys/image_pipeline.h
+++ b/backend/genesys/image_pipeline.h
@@ -524,8 +524,19 @@ class ImagePipelineStack
 {
 public:
     ImagePipelineStack() {}
-    ImagePipelineStack(ImagePipelineStack&&) = default;
-    ImagePipelineStack& operator=(ImagePipelineStack&&) = default;
+    ImagePipelineStack(ImagePipelineStack&& other)
+    {
+        clear();
+        nodes_ = std::move(other.nodes_);
+    }
+
+    ImagePipelineStack& operator=(ImagePipelineStack&& other)
+    {
+        clear();
+        nodes_ = std::move(other.nodes_);
+        return *this;
+    }
+
     ~ImagePipelineStack() { clear(); }
 
     std::size_t get_input_width() const;

From 8a66829057e47cb6dd6ea5e00d7a097c9dd069a0 Mon Sep 17 00:00:00 2001
From: Povilas Kanapickas <povilas@radix.lt>
Date: Tue, 26 May 2020 01:13:20 +0300
Subject: [PATCH 3/3] genesys: Simplify access to nodes that are newly added to
 image pipeline

---
 backend/genesys/image_pipeline.h | 24 +++++++-----------------
 backend/genesys/low.cpp          |  8 +++-----
 2 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/backend/genesys/image_pipeline.h b/backend/genesys/image_pipeline.h
index 0e3264a72..d4aef49e6 100644
--- a/backend/genesys/image_pipeline.h
+++ b/backend/genesys/image_pipeline.h
@@ -556,32 +556,22 @@ public:
     void clear();
 
     template<class Node, class... Args>
-    void push_first_node(Args&&... args)
-    {
-        push_first_node(std::unique_ptr<Node>(new Node(std::forward<Args>(args)...)));
-    }
-
-    template<class Node>
-    void push_first_node(std::unique_ptr<Node>&& node)
+    Node& push_first_node(Args&&... args)
     {
         if (!nodes_.empty()) {
             throw SaneException("Trying to append first node when there are existing nodes");
         }
-        nodes_.emplace_back(std::move(node));
+        nodes_.emplace_back(std::unique_ptr<Node>(new Node(std::forward<Args>(args)...)));
+        return static_cast<Node&>(*nodes_.back());
     }
 
     template<class Node, class... Args>
-    void push_node(Args&&... args)
+    Node& push_node(Args&&... args)
     {
         ensure_node_exists();
-        push_node(std::unique_ptr<Node>(new Node(*nodes_.back(), std::forward<Args>(args)...)));
-    }
-
-    template<class Node, class... Args>
-    void push_node(std::unique_ptr<Node>&& node)
-    {
-        ensure_node_exists();
-        nodes_.emplace_back(std::move(node));
+        nodes_.emplace_back(std::unique_ptr<Node>(new Node(*nodes_.back(),
+                                                           std::forward<Args>(args)...)));
+        return static_cast<Node&>(*nodes_.back());
     }
 
     bool get_next_row_data(std::uint8_t* out_data)
diff --git a/backend/genesys/low.cpp b/backend/genesys/low.cpp
index e4dec048c..564a0795a 100644
--- a/backend/genesys/low.cpp
+++ b/backend/genesys/low.cpp
@@ -915,11 +915,9 @@ ImagePipelineStack build_image_pipeline(const Genesys_Device& dev, const ScanSes
     // certain circumstances.
     buffer_size = align_multiple_ceil(buffer_size, 2);
 
-    auto node = std::unique_ptr<ImagePipelineNodeBufferedCallableSource>(
-                new ImagePipelineNodeBufferedCallableSource(
-                    width, lines, format, buffer_size, read_data_from_usb));
-    node->set_last_read_multiple(2);
-    pipeline.push_first_node(std::move(node));
+    auto& src_node = pipeline.push_first_node<ImagePipelineNodeBufferedCallableSource>(
+                          width, lines, format, buffer_size, read_data_from_usb);
+    src_node.set_last_read_multiple(2);
 
     if (log_image_data) {
         pipeline.push_node<ImagePipelineNodeDebug>(debug_prefix + "_0_from_usb.tiff");