From 575f40a0790bb5e20ffd7ccae1c9272e481bbe51 Mon Sep 17 00:00:00 2001 From: Nils Philippsen Date: Tue, 5 Nov 2013 15:12:20 +0100 Subject: [PATCH] pixma: avoid buffer overflows --- backend/pixma_bjnp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/backend/pixma_bjnp.c b/backend/pixma_bjnp.c index 7bdd76a7a..cd196e3c1 100644 --- a/backend/pixma_bjnp.c +++ b/backend/pixma_bjnp.c @@ -284,7 +284,8 @@ parse_IEEE1284_to_model (char *scanner_id, char *model) char s[BJNP_IEEE1284_MAX]; char *tok; - strcpy (s, scanner_id); + strncpy (s, scanner_id, BJNP_IEEE1284_MAX); + s[BJNP_IEEE1284_MAX - 1] = '\0'; model[0] = '\0'; tok = strtok (s, ";"); @@ -441,7 +442,8 @@ split_uri (const char *devname, char *method, char *host, char *port, char next; int i; - strcpy (copy, devname); + strncpy (copy, devname, 1024); + copy[1023] = '\0'; start = copy; /*