Add fake names to fake devices

strcmp() does not protect against NULL pointers and is
crashing on at least OS X for the fake devices we are creating
by setting device_number to MAX value.

Add a fake empty string to prevent this.
merge-requests/1/head
Chris Bagwell 2013-08-16 13:10:32 -05:00
rodzic 317626116f
commit 43da1e64c1
1 zmienionych plików z 7 dodań i 0 usunięć

Wyświetl plik

@ -163,6 +163,10 @@ test_store_device (void)
* to store device */
current_number = device_number;
device_number = MAX_DEVICES;
/* give unused devices a name so strcmp() won't crash. */
for (i = current_number; i < MAX_DEVICES; i++)
devices[i].devname = "";
store_device (mock);
/* there should be no more devices */
if (device_number > MAX_DEVICES)
@ -183,6 +187,9 @@ test_store_device (void)
/* restore device_number */
device_number = current_number;
/* reset unused devnames to NULL */
for (i = current_number; i < MAX_DEVICES; i++)
devices[i].devname = NULL;
expected = device_number + 1;
/* store mock device */