Fix memory clobbering issue in sane.model creation

merge-requests/1/head
Ilya Gordeev 2014-04-21 04:11:00 +09:00 zatwierdzone przez m. allan noah
rodzic 98e4ee4084
commit 16dc9c87a6
2 zmienionych plików z 4 dodań i 6 usunięć

Wyświetl plik

@ -248,10 +248,9 @@ attach (const char *devnam, Ibm_Device ** devp)
dev->sane.name = strdup (devnam);
dev->sane.vendor = "IBM";
str = malloc (16 + 1);
memset (str, 0, sizeof (str));
str = malloc (sizeof(ibuf.product) + sizeof(ibuf.revision) + 1);
strncpy (str, (char *)ibuf.product, sizeof(ibuf.product));
strncpy (str + sizeof(ibuf.revision), (char *)ibuf.revision, sizeof(ibuf.revision));
strncpy (str + sizeof(ibuf.product), (char *)ibuf.revision, sizeof(ibuf.revision));
str[sizeof(ibuf.product) + sizeof(ibuf.revision)] = '\0';
dev->sane.model = str;
dev->sane.type = "flatbed scanner";

Wyświetl plik

@ -222,10 +222,9 @@ attach (const char *devnam, Ricoh_Device ** devp)
dev->sane.name = strdup (devnam);
dev->sane.vendor = "RICOH";
str = malloc (16 + 1);
memset (str, 0, sizeof (str));
str = malloc (sizeof(ibuf.product) + sizeof(ibuf.revision) + 1);
strncpy (str, (char *)ibuf.product, sizeof(ibuf.product));
strncpy (str + sizeof(ibuf.revision), (char *)ibuf.revision, sizeof(ibuf.revision));
strncpy (str + sizeof(ibuf.product), (char *)ibuf.revision, sizeof(ibuf.revision));
str[sizeof(ibuf.product) + sizeof(ibuf.revision)] = '\0';
dev->sane.model = str;
dev->sane.type = "flatbed scanner";