Upgrade to SpotBugs 4.2.0

Also fix new violation.  Changelog:

https://github.com/spotbugs/spotbugs/blob/4.4.0/CHANGELOG.md
pull/369/head
Andrew Gaul 2021-08-21 08:11:21 +09:00
rodzic f4ea296adf
commit 79f12eff88
2 zmienionych plików z 11 dodań i 4 usunięć

Wyświetl plik

@ -246,7 +246,14 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.0.5</version>
<version>4.2.0</version>
<dependencies>
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>4.4.0</version>
</dependency>
</dependencies>
<configuration>
<effort>Max</effort>
<omitVisitors>CrossSiteScripting,DefaultEncodingDetector,FindNullDeref</omitVisitors>

Wyświetl plik

@ -216,9 +216,9 @@ final class ShardedBlobStore extends ForwardingBlobStore {
String container) {
Map<String, String> currentSuperblockMeta =
blob.getMetadata().getUserMetadata();
for (String key : expectedMeta.keySet()) {
String current = currentSuperblockMeta.get(key);
String expected = expectedMeta.get(key);
for (Map.Entry<String, String> entry : expectedMeta.entrySet()) {
String current = currentSuperblockMeta.get(entry.getKey());
String expected = entry.getValue();
if (!expected.equalsIgnoreCase(current)) {
throw new RuntimeException(String.format(
"Superblock block for %s does not match: %s, %s",