From 559b1d36dd6dfc27f2208d7cadc55d0f713855f3 Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Tue, 5 Aug 2014 10:46:18 -0700 Subject: [PATCH] Clean up signer --- .../java/org/gaul/s3proxy/S3ProxyHandler.java | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/main/java/org/gaul/s3proxy/S3ProxyHandler.java b/src/main/java/org/gaul/s3proxy/S3ProxyHandler.java index e4afc21..7b89c4f 100644 --- a/src/main/java/org/gaul/s3proxy/S3ProxyHandler.java +++ b/src/main/java/org/gaul/s3proxy/S3ProxyHandler.java @@ -975,17 +975,14 @@ final class S3ProxyHandler extends AbstractHandler { // build string to sign StringBuilder builder = new StringBuilder() - .append(request.getMethod()).append('\n'); - String contentMD5 = request.getHeader(HttpHeaders.CONTENT_MD5); - if (contentMD5 != null) { - builder.append(contentMD5); - } - builder.append('\n'); - String contentType = request.getHeader(HttpHeaders.CONTENT_TYPE); - if (contentType != null) { - builder.append(contentType); - } - builder.append('\n'); + .append(request.getMethod()) + .append('\n') + .append(Strings.nullToEmpty(request.getHeader( + HttpHeaders.CONTENT_MD5))) + .append('\n') + .append(Strings.nullToEmpty(request.getHeader( + HttpHeaders.CONTENT_TYPE))) + .append('\n'); String expires = request.getParameter("Expires"); if (expires != null) { builder.append(expires);