As I was debugging https://github.com/jupyterhub/repo2docker/pull/1388,
I realized that PR actually broke the dataverse provider, but the
existing test was mocking so much that we didn't actually catch it!
IMO, since the point of contentproviders is to integrate with
external content providers, they should be integration tests so we
can catch issues with them more easily. Integration tests would have
caught https://jupyter.zulipchat.com/#narrow/channel/103349-ask-anything/topic/Binder.20Dataverse.20error
more cleanly than how it happened for example.
This PR removes all mocks from the dataverse test, and we immediately
benefit - it shows us that the dataverse provider *only* actually
handles DOIs, and not direct URLs! So even though we technically
had tests earlier that showed our dataverse provider supporting direct
dataverse URLs, it simply was not true. So we actually catch the
failure.
I will try to see if we can use a demo or test instance for the
fetch test though, so we don't screw up download stats even more
for the existing test doi we use.
YuviPanda