From e95300fa2537bb5d72c3b57e282e4f376812ddee Mon Sep 17 00:00:00 2001 From: David Anthoff Date: Mon, 25 Feb 2019 15:51:20 -0800 Subject: [PATCH] Add comments to julia pack --- repo2docker/buildpacks/julialegacy/__init__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/repo2docker/buildpacks/julialegacy/__init__.py b/repo2docker/buildpacks/julialegacy/__init__.py index bf71d229..c14be85a 100644 --- a/repo2docker/buildpacks/julialegacy/__init__.py +++ b/repo2docker/buildpacks/julialegacy/__init__.py @@ -157,14 +157,14 @@ class JuliaLegacyBuildPack(PythonBuildPack): def detect(self): """ - Check if current repo should be built with the Julia Build pack + Check if current repo should be built with the Julia Legacy Build pack super().detect() is not called in this function - it would return false unless an `environment.yml` is present and we do not want to require the presence of a `environment.yml` to use Julia. - Instead we just check if the path to `REQUIRE` exists + Instead we just check if the path to `REQUIRE` exists and that there is + no julia 1.0 style environment """ - # TODO(nhdaly): Add support for Project.toml here as well. return os.path.exists(self.binder_path('REQUIRE')) and not(os.path.exists(self.binder_path('Project.toml')) or os.path.exists(self.binder_path('JuliaProject.toml')))