mirror
/
repo2docker
kopia lustrzana https://github.com/jupyterhub/repo2docker
1
0
Forkuj 0
Kod Zgłoszenia Projekty Wydania Wiki Aktywność

Added docstring for image_name validation test

pull/175/head
Mukundan Sundararajan 2017-12-22 04:31:41 -08:00
rodzic f04aa4da97
commit d3cf4793e4
1 zmienionych plików z 4 dodań i 2 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

6
tests/argumentvalidation.py
Wyświetl plik

@ -17,11 +17,9 @@ def does_validate_image_name(builddir, image_name):
], ],
stderr=subprocess.STDOUT, stderr=subprocess.STDOUT,
).decode() ).decode()
print(output)
return True return True
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
output = e.output.decode() output = e.output.decode()
print(output)
if "error: argument --image-name: %r is not a valid docker image name. " \ if "error: argument --image-name: %r is not a valid docker image name. " \
"Image name can contain only lowercase characters." % image_name in output: "Image name can contain only lowercase characters." % image_name in output:
return False return False
@ -29,6 +27,10 @@ def does_validate_image_name(builddir, image_name):
raise raise
def test_image_name_fail(): def test_image_name_fail():
"""
Test to check if repo2docker throws image_name validation error on --image-name argument containing uppercase characters.
"""
builddir = os.path.dirname(__file__) builddir = os.path.dirname(__file__)
assert not does_validate_image_name(builddir, 'Test/Invalid_name:1.0.0') assert not does_validate_image_name(builddir, 'Test/Invalid_name:1.0.0')