diff --git a/repo2docker/detectors.py b/repo2docker/detectors.py index 6b10f543..b377dfc0 100644 --- a/repo2docker/detectors.py +++ b/repo2docker/detectors.py @@ -554,7 +554,7 @@ class CondaBuildPack(BuildPack): conda clean -tipsy """ )) - if os.path.exists('requirements.txt'): + elif os.path.exists('requirements.txt'): assembly_scripts.append(( '${NB_USER}', 'pip install --no-cache-dir -r requirements.txt' diff --git a/tests/conda/requirements/README.rst b/tests/conda/requirements/README.rst index 336282f0..afb58840 100644 --- a/tests/conda/requirements/README.rst +++ b/tests/conda/requirements/README.rst @@ -1,5 +1,12 @@ Python - Mixed Requirements --------------------------- -You can specify both a ``requirements.txt`` and an ``environment.yml`` file, -and both of these will be used to build your environment. +An ``environment.yml`` takes precedence over ``requirements.txt``. +To install files into a conda environment with pip, use the ``pip`` key in ``environment.yml``: + +.. sourcecode:: yaml + + dependencies: + - numpy + - pip: + - tornado diff --git a/tests/conda/requirements/environment.yml b/tests/conda/requirements/environment.yml index 6a91d667..fa9404c5 100644 --- a/tests/conda/requirements/environment.yml +++ b/tests/conda/requirements/environment.yml @@ -1,2 +1,4 @@ dependencies: - numpy + - pip: + - simplejson diff --git a/tests/conda/requirements/verify b/tests/conda/requirements/verify index d220a895..8f344fdc 100755 --- a/tests/conda/requirements/verify +++ b/tests/conda/requirements/verify @@ -4,4 +4,9 @@ import sys assert sys.version_info[:2] == (3, 6) import numpy -import there +try: + import there +except ImportError: + print('ok') +else: + raise Exception("'there' shouldn't have been installed from requirements.txt")