From 885cb464b6904ae56a356cc858135d93ce1359ac Mon Sep 17 00:00:00 2001
From: YuviPanda <yuvipanda@gmail.com>
Date: Wed, 26 Jan 2022 14:45:38 +0530
Subject: [PATCH 1/2] Allow passing in traitlets via commandline

Without this, you *always* needed a repo2docker_config.py
file to configure anything. This PR makes r2d match the
behavior of most traitlets based applications (like jupyter_server,
jupyterhub, nbconvert, etc)

Fixes https://github.com/jupyterhub/repo2docker/issues/1112
---
 repo2docker/__main__.py | 3 ++-
 repo2docker/app.py      | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/repo2docker/__main__.py b/repo2docker/__main__.py
index 09916169..c4e46e19 100644
--- a/repo2docker/__main__.py
+++ b/repo2docker/__main__.py
@@ -251,9 +251,10 @@ def make_r2d(argv=None):
         print(__version__)
         sys.exit(0)
 
-    args = get_argparser().parse_args(argv)
+    args, traitlet_args = get_argparser().parse_known_args(argv)
 
     r2d = Repo2Docker()
+    r2d.parse_command_line(traitlet_args)
 
     if args.debug:
         r2d.log_level = logging.DEBUG
diff --git a/repo2docker/app.py b/repo2docker/app.py
index a03fe1df..ce49fc7f 100755
--- a/repo2docker/app.py
+++ b/repo2docker/app.py
@@ -490,7 +490,7 @@ class Repo2Docker(Application):
             extra=dict(phase="failed"),
         )
 
-    def initialize(self):
+    def initialize(self, *args, **kwargs):
         """Init repo2docker configuration before start"""
         # FIXME: Remove this function, move it to setters / traitlet reactors
         if self.json_logs:

From 710d533f75bb7554eba41c22d9cf9837f7d99707 Mon Sep 17 00:00:00 2001
From: Min RK <benjaminrk@gmail.com>
Date: Thu, 27 Jan 2022 14:01:45 +0100
Subject: [PATCH 2/2] add `--help-all` support

a bit funky, since we are combining two separate parsers
---
 repo2docker/__main__.py | 31 +++++++++++++++++++++++--------
 repo2docker/app.py      |  4 ++++
 2 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/repo2docker/__main__.py b/repo2docker/__main__.py
index c4e46e19..5dd139ec 100644
--- a/repo2docker/__main__.py
+++ b/repo2docker/__main__.py
@@ -66,6 +66,20 @@ def get_argparser():
         description="Fetch a repository and build a container image"
     )
 
+    argparser.add_argument(
+        "--help-all",
+        dest="help_all",
+        action="store_true",
+        help="Display all configurable options and exit.",
+    )
+
+    argparser.add_argument(
+        "--version",
+        dest="version",
+        action="store_true",
+        help="Print the repo2docker version and exit.",
+    )
+
     argparser.add_argument(
         "--config",
         default="repo2docker_config.py",
@@ -222,13 +236,6 @@ def get_argparser():
 
     argparser.add_argument("--subdir", type=str, help=Repo2Docker.subdir.help)
 
-    argparser.add_argument(
-        "--version",
-        dest="version",
-        action="store_true",
-        help="Print the repo2docker version and exit.",
-    )
-
     argparser.add_argument(
         "--cache-from", action="append", default=[], help=Repo2Docker.cache_from.help
     )
@@ -245,13 +252,21 @@ def make_r2d(argv=None):
     if argv is None:
         argv = sys.argv[1:]
 
+    argparser = get_argparser()
+
     # version must be checked before parse, as repo/cmd are required and
     # will spit out an error if allowed to be parsed first.
     if "--version" in argv:
         print(__version__)
         sys.exit(0)
 
-    args, traitlet_args = get_argparser().parse_known_args(argv)
+    if "--help-all" in argv:
+        argparser.print_help()
+        print("\nAll configurable options:\n")
+        Repo2Docker().print_help(classes=True)
+        sys.exit(0)
+
+    args, traitlet_args = argparser.parse_known_args(argv)
 
     r2d = Repo2Docker()
     r2d.parse_command_line(traitlet_args)
diff --git a/repo2docker/app.py b/repo2docker/app.py
index ce49fc7f..8c896828 100755
--- a/repo2docker/app.py
+++ b/repo2docker/app.py
@@ -47,6 +47,10 @@ class Repo2Docker(Application):
     name = "jupyter-repo2docker"
     version = __version__
     description = __doc__
+    # disable aliases/flags because we don't use the traitlets for CLI parsing
+    # other than --Class.trait=value
+    aliases = {}
+    flags = {}
 
     @default("log_level")
     def _default_log_level(self):