Add more docstrings in R BuildPack

- Version-pin the devtools package installation independent of
  the current version
- Make sure get_build_scripts is independent of contents of
  current repository
pull/210/head
yuvipanda 2018-02-02 17:38:36 -08:00
rodzic 25611f0230
commit 39d3e6a8f7
1 zmienionych plików z 89 dodań i 34 usunięć

Wyświetl plik

@ -10,19 +10,19 @@ class RBuildPack(PythonBuildPack):
This sets up R + RStudio + IRKernel for a repository that contains:
1. A `runtime.txt` file with the text:
1. A `runtime.txt` file with the text:
r-<year>-<month>-<date>
r-<year>-<month>-<date>
Where 'year', 'month' and 'date' refer to a specific
date snapshot of https://mran.microsoft.com/timemachine
from which libraries are to be installed.
Where 'year', 'month' and 'date' refer to a specific
date snapshot of https://mran.microsoft.com/timemachine
from which libraries are to be installed.
2. An optional `install.R` file that will be executed at build time,
and can be used for installing packages from both MRAN and GitHub.
2. An optional `install.R` file that will be executed at build time,
and can be used for installing packages from both MRAN and GitHub.
It currently sets up R from the ubuntu repository being used. This
is unideal, and we should investigate other solutions!
The `r-base` package from Ubuntu apt repositories is used to install
R itself, rather than any of the methods from https://cran.r-project.org/.
"""
@property
def runtime(self):
@ -59,23 +59,48 @@ class RBuildPack(PythonBuildPack):
"""
Check if current repo should be built with the R Build pack
Note that we explicitly do *not* check if a requirements.txt
is present here (by calling super().detect()).
super().detect() is not called in this function - it would return false
unless a `requirements.txt` is present and we do not want to require the
presence of a `requirements.txt` to use R.
Instead we just check if runtime.txt contains a string of the form
`r-<YYYY>-<MM>-<DD>`
"""
# If no date is found, then self.checkpoint_date will be False
# Otherwise, it'll be a date object, which will evaluate to True
return bool(self.checkpoint_date)
def get_path(self):
"""
Return paths to be added to the PATH environment variable.
The RStudio package installs its binaries in a non-standard path,
so we explicitly add that path to PATH.
"""
return super().get_path() + [
'/usr/lib/rstudio-server/bin/'
]
def get_env(self):
"""
Return environment variables to be set.
We want libraries to be installed in a path that users can write to
without needing root. This is set via the `R_LIBS_USER` environment
variable, so we set that here.
"""
return super().get_env() + [
# This is the path where user libraries are installed
('R_LIBS_USER', '${APP_BASE}/rlibs')
]
def get_packages(self):
"""
Return list of packages to be installed.
We install a base version of R, and packages required for RStudio to
be installed.
"""
return super().get_packages().union([
'r-base',
# For rstudio
@ -86,12 +111,29 @@ class RBuildPack(PythonBuildPack):
])
def get_build_scripts(self):
mran_url = 'https://mran.microsoft.com/snapshot/{}'.format(
self.checkpoint_date.isoformat()
)
"""
Return series of build-steps common to all R repositories
All scripts here should be independent of contents of the repository.
This sets up:
- A directory owned by non-root in ${R_LIBS_USER} for installing R packages into
- RStudio
- R's devtools package, at a particular frozen version (determined by MRAN)
- IRKernel
- nbrsessionproxy (to access RStudio via Jupyter Notebook)
"""
rstudio_url = 'https://download2.rstudio.org/rstudio-server-1.1.419-amd64.deb'
# This is MD5, because that is what RStudio download page provides!
rstudio_checksum = '24cd11f0405d8372b4168fc9956e0386'
# Version of MRAN to pull devtools from.
devtools_version = '2018-02-01'
# IRKernel version - specified as a tag in the IRKernel repository
irkernel_version = '0.8.11'
return super().get_build_scripts() + [
(
"root",
@ -100,19 +142,11 @@ class RBuildPack(PythonBuildPack):
chown -R ${NB_USER}:${NB_USER} ${R_LIBS_USER}
"""
),
(
"root",
# We set the default CRAN repo to the MRAN one at given date
# We set download method to be curl so we get HTTPS support
r"""
echo "options(repos = c(CRAN='{mran_url}'), download.file.method = 'libcurl')" > /etc/R/Rprofile.site
""".format(mran_url=mran_url)
),
(
"root",
# Install RStudio!
r"""
curl -L --fail {rstudio_url} > /tmp/rstudio.deb && \
curl --quiet -L --fail {rstudio_url} > /tmp/rstudio.deb && \
echo '{rstudio_checksum} /tmp/rstudio.deb' | md5sum -c - && \
dpkg -i /tmp/rstudio.deb && \
rm /tmp/rstudio.deb
@ -121,15 +155,6 @@ class RBuildPack(PythonBuildPack):
rstudio_checksum=rstudio_checksum
)
),
(
"${NB_USER}",
# Install a pinned version of IRKernel and set it up for use!
r"""
R --quiet -e "install.packages('devtools')" && \
R --quiet -e "devtools::install_github('IRkernel/IRkernel', ref='0.8.11')" && \
R --quiet -e "IRkernel::installspec(prefix='${NB_PYTHON_PREFIX}')"
"""
),
(
"${NB_USER}",
# Install nbrsessionproxy
@ -139,12 +164,42 @@ class RBuildPack(PythonBuildPack):
jupyter nbextension install --py nbrsessionproxy --sys-prefix && \
jupyter nbextension enable --py nbrsessionproxy --sys-prefix
"""
),
(
"${NB_USER}",
# Install a pinned version of IRKernel and set it up for use!
r"""
R --quiet -e "install.packages('devtools', repos='https://mran.microsoft.com/snapshot/{devtools_version}', method='libcurl')" && \
R --quiet -e "devtools::install_github('IRkernel/IRkernel', ref='{irkernel_version}')" && \
R --quiet -e "IRkernel::installspec(prefix='$NB_PYTHON_PREFIX')"
""".format(
devtools_version=devtools_version,
irkernel_version=irkernel_version
)
)
]
def get_assemble_scripts(self):
assemble_scripts = super().get_assemble_scripts()
"""
Return series of build-steps specific to this repository
We set the snapshot date used to install R libraries from based on the
contents of runtime.txt, and run the `install.R` script if it exists.
"""
mran_url = 'https://mran.microsoft.com/snapshot/{}'.format(
self.checkpoint_date.isoformat()
)
assemble_scripts = super().get_assemble_scripts() + [
(
"root",
# We set the default CRAN repo to the MRAN one at given date
# We set download method to be curl so we get HTTPS support
r"""
echo "options(repos = c(CRAN='{mran_url}'), download.file.method = 'libcurl')" > /etc/R/Rprofile.site
""".format(mran_url=mran_url)
),
]
if os.path.exists('install.R'):
assemble_scripts += [
(