From 313d495f325a249b10a96a47f038b6268befb24d Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Sat, 8 Oct 2022 13:43:40 +0200 Subject: [PATCH] ci: trim away some comments now common knowledge --- .github/workflows/release.yml | 2 -- .github/workflows/test.yml | 15 ++++----------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4672d7f5..22580ceb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,7 +30,6 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - - uses: actions/setup-python@v4 with: python-version: "3.8" @@ -85,7 +84,6 @@ jobs: # Setup docker to build for multiple platforms, see: # https://github.com/docker/build-push-action/tree/v2.4.0#usage # https://github.com/docker/build-push-action/blob/v2.4.0/docs/advanced/multi-platform.md - - name: Set up QEMU (for docker buildx) uses: docker/setup-qemu-action@v2 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 05fb789f..285b42fa 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -39,12 +39,10 @@ env: GIT_AUTHOR_NAME: CI User jobs: - # Job to run linter / autoformat - lint: + pre-commit: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - - uses: actions/setup-python@v4 with: python-version: "3.8" @@ -64,16 +62,12 @@ jobs: pip install --upgrade -r dev-requirements.txt pip freeze - - name: "Run linter" - run: | - pre-commit run --all-files + - run: pre-commit run --all-files test: - # Previous job must have successfully completed for this job to execute - # - https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idneeds - needs: lint + needs: pre-commit runs-on: ubuntu-20.04 - # - https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategy + strategy: fail-fast: false # Do not cancel all jobs if one fails matrix: @@ -95,7 +89,6 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions/setup-python@v4 with: python-version: "${{ matrix.python_version }}"