mirror
/
repo2docker
kopia lustrzana https://github.com/jupyterhub/repo2docker
1
0
Forkuj 0
Kod Zgłoszenia Projekty Wydania Wiki Aktywność

update tests for image name validation

pull/213/head
Carol Willing 2018-03-15 16:54:45 -07:00
rodzic 8a3f79f154
commit 2c60b0f708
1 zmienionych plików z 20 dodań i 10 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

30
tests/argumentvalidation.py
Wyświetl plik

@ -34,8 +34,11 @@ def test_image_name_fail():
builddir = os.path.dirname(__file__) builddir = os.path.dirname(__file__)
image_name = 'Test/Invalid_name:1.0.0' image_name = 'Test/Invalid_name:1.0.0'
args_list = ['--no-run', '--no-build', '--image-name', image_name] args_list = ['--no-run', '--no-build', '--image-name', image_name]
expected = "error: argument --image-name: %r is not a valid docker image name. " \ expected = (
"Image name can contain only lowercase characters." % image_name "%r is not a valid docker image name. Image name"
"must start with an alphanumeric character and"
"can then use _ . or - in addition to alphanumeric." % image_name
)
assert not validate_arguments(builddir, args_list, expected) assert not validate_arguments(builddir, args_list, expected)
@ -47,9 +50,11 @@ def test_image_name_underscore_fail():
builddir = os.path.dirname(__file__) builddir = os.path.dirname(__file__)
image_name = '_test/invalid_name:1.0.0' image_name = '_test/invalid_name:1.0.0'
args_list = ['--no-run', '--no-build', '--image-name', image_name] args_list = ['--no-run', '--no-build', '--image-name', image_name]
expected = "error: argument --image-name: %r is not a valid docker image name. " \ expected = (
"Image name can contain only lowercase characters." % image_name "%r is not a valid docker image name. Image name"
"must start with an alphanumeric character and"
"can then use _ . or - in addition to alphanumeric." % image_name
)
assert not validate_arguments(builddir, args_list, expected) assert not validate_arguments(builddir, args_list, expected)
@ -61,9 +66,11 @@ def test_image_name_double_dot_fail():
builddir = os.path.dirname(__file__) builddir = os.path.dirname(__file__)
image_name = 'test..com/invalid_name:1.0.0' image_name = 'test..com/invalid_name:1.0.0'
args_list = ['--no-run', '--no-build', '--image-name', image_name] args_list = ['--no-run', '--no-build', '--image-name', image_name]
expected = "error: argument --image-name: %r is not a valid docker image name. " \ expected = (
"Image name can contain only lowercase characters." % image_name "%r is not a valid docker image name. Image name"
"must start with an alphanumeric character and"
"can then use _ . or - in addition to alphanumeric." % image_name
)
assert not validate_arguments(builddir, args_list, expected) assert not validate_arguments(builddir, args_list, expected)
@ -76,8 +83,11 @@ def test_image_name_valid_restircted_registry_domain_name_fail():
builddir = os.path.dirname(__file__) builddir = os.path.dirname(__file__)
image_name = 'Test.com/valid_name:1.0.0' image_name = 'Test.com/valid_name:1.0.0'
args_list = ['--no-run', '--no-build', '--image-name', image_name] args_list = ['--no-run', '--no-build', '--image-name', image_name]
expected = "error: argument --image-name: %r is not a valid docker image name. " \ expected = (
"Image name can contain only lowercase characters." % image_name "%r is not a valid docker image name. Image name"
"must start with an alphanumeric character and"
"can then use _ . or - in addition to alphanumeric." % image_name
)
assert not validate_arguments(builddir, args_list, expected) assert not validate_arguments(builddir, args_list, expected)