From 12233c4320dfbd7caaf351c8d9e3d048bf06a766 Mon Sep 17 00:00:00 2001 From: Hank Grabowski Date: Mon, 27 Nov 2023 13:16:11 -0600 Subject: [PATCH] Tweaks to logging levels --- lib/controls/audio_video/media_kit_av_control.dart | 2 +- lib/controls/timeline/interactions_bar_control.dart | 12 ++++++------ lib/controls/timeline/post_control.dart | 2 +- lib/friendica_client/friendica_client.dart | 2 ++ lib/screens/editor.dart | 8 ++++---- lib/screens/filter_editor_screen.dart | 2 +- lib/screens/gallery_browsers_screen.dart | 2 +- lib/screens/gallery_screen.dart | 4 ++-- lib/screens/home.dart | 2 +- lib/screens/notifications_screen.dart | 2 +- lib/screens/search_screen.dart | 4 ++-- lib/services/blocks_manager.dart | 8 ++++---- lib/services/timeline_manager.dart | 6 +++--- lib/utils/network_utils.dart | 8 ++++---- 14 files changed, 33 insertions(+), 31 deletions(-) diff --git a/lib/controls/audio_video/media_kit_av_control.dart b/lib/controls/audio_video/media_kit_av_control.dart index 73d868b..fd04e9b 100644 --- a/lib/controls/audio_video/media_kit_av_control.dart +++ b/lib/controls/audio_video/media_kit_av_control.dart @@ -57,7 +57,7 @@ class _MediaKitAvControlState extends State { @override Widget build(BuildContext context) { - _logger.finer('Building MediaKit Control for ${widget.videoUrl}'); + _logger.finest('Building MediaKit Control for ${widget.videoUrl}'); if (controller == null) { return Container( width: widget.width, diff --git a/lib/controls/timeline/interactions_bar_control.dart b/lib/controls/timeline/interactions_bar_control.dart index c16cbeb..810dd93 100644 --- a/lib/controls/timeline/interactions_bar_control.dart +++ b/lib/controls/timeline/interactions_bar_control.dart @@ -51,14 +51,14 @@ class _InteractionsBarControlState extends State { isProcessing = true; }); final newState = !isFavorited; - _logger.finest('Trying to toggle favorite from $isFavorited to $newState'); + _logger.fine('Trying to toggle favorite from $isFavorited to $newState'); final result = await getIt>() .activeEntry .andThenAsync( (tm) async => await tm.toggleFavorited(widget.entry.id, newState)); result.match(onSuccess: (update) { setState(() { - _logger.finest( + _logger.fine( 'Success toggling! $isFavorited -> ${update.entry.isFavorited}'); }); }, onError: (error) { @@ -93,14 +93,14 @@ class _InteractionsBarControlState extends State { } final id = widget.entry.id; - _logger.finest('Trying to reshare $id'); + _logger.fine('Trying to reshare $id'); final result = await getIt>() .activeEntry .andThenAsync((tm) async => await tm.resharePost(id)); result.match(onSuccess: (update) { setState(() { - _logger.finest('Success resharing post by ${widget.entry.author}'); + _logger.fine('Success resharing post by ${widget.entry.author}'); }); }, onError: (error) { buildSnackbar(context, 'Error resharing post by ${widget.entry.author}'); @@ -122,13 +122,13 @@ class _InteractionsBarControlState extends State { isProcessing = true; }); final id = widget.entry.id; - _logger.finest('Trying to un-reshare $id'); + _logger.fine('Trying to un-reshare $id'); final result = await getIt>() .activeEntry .andThenAsync((tm) async => await tm.unResharePost(id)); result.match(onSuccess: (update) { setState(() { - _logger.finest('Success un-resharing post by ${widget.entry.author}'); + _logger.fine('Success un-resharing post by ${widget.entry.author}'); }); }, onError: (error) { buildSnackbar( diff --git a/lib/controls/timeline/post_control.dart b/lib/controls/timeline/post_control.dart index 5eef249..145486b 100644 --- a/lib/controls/timeline/post_control.dart +++ b/lib/controls/timeline/post_control.dart @@ -74,7 +74,7 @@ class _PostControlState extends State { final int scrollToIndex = _scrollToIndexCalc(items); // TODO Figure out why doesn't scroll to correct position on loading - _logger.finer('Building view with initial position at $scrollToIndex'); + _logger.finest('Building view with initial position at $scrollToIndex'); return ScrollablePositionedList.builder( physics: const AlwaysScrollableScrollPhysics(), diff --git a/lib/friendica_client/friendica_client.dart b/lib/friendica_client/friendica_client.dart index d627af0..7a0d6b7 100644 --- a/lib/friendica_client/friendica_client.dart +++ b/lib/friendica_client/friendica_client.dart @@ -817,6 +817,8 @@ class StatusesClient extends FriendicaClient { ...descendants .map((d) => TimelineEntryMastodonExtensions.fromJson(d)) ]; + _logger.finer(() => + 'Got status $id with full context which returned ${ancestors.length} ancestors and ${descendants.length} descendants'); return items; } else { return [TimelineEntryMastodonExtensions.fromJson(json)]; diff --git a/lib/screens/editor.dart b/lib/screens/editor.dart index 8d6d9ab..99ce270 100644 --- a/lib/screens/editor.dart +++ b/lib/screens/editor.dart @@ -84,7 +84,7 @@ class _EditorScreenState extends State { parentEntry = entry; visibility = entry.visibility; }, onError: (error) { - _logger.finest('Error trying to get parent entry: $error'); + _logger.severe('Error trying to get parent entry: $error'); }); } @@ -96,13 +96,13 @@ class _EditorScreenState extends State { } void restoreStatusData() async { - _logger.fine('Attempting to load status for editing'); + _logger.finer('Attempting to load status for editing'); loaded = false; final result = await getIt>() .activeEntry .andThenAsync((manager) async => manager.getEntryById(widget.id)); result.match(onSuccess: (entry) { - _logger.fine('Loading status ${widget.id} information into fields'); + _logger.finer('Loading status ${widget.id} information into fields'); contentController.text = htmlToSimpleText(entry.body); spoilerController.text = entry.spoilerText; existingMediaItems @@ -227,7 +227,7 @@ class _EditorScreenState extends State { @override Widget build(BuildContext context) { - _logger.finest('Build editor $isComment $parentEntry'); + _logger.finer('Build editor $isComment $parentEntry'); final manager = context .read>() .activeEntry diff --git a/lib/screens/filter_editor_screen.dart b/lib/screens/filter_editor_screen.dart index 9434b9a..244a9d8 100644 --- a/lib/screens/filter_editor_screen.dart +++ b/lib/screens/filter_editor_screen.dart @@ -67,7 +67,7 @@ class _FilterEditorScreenState extends State { @override Widget build(BuildContext context) { - _logger.finer('Build for filter ${widget.id}'); + _logger.finest('Build for filter ${widget.id}'); final fieldWidth = MediaQuery.of(context).size.width * 0.8; final service = context .watch>() diff --git a/lib/screens/gallery_browsers_screen.dart b/lib/screens/gallery_browsers_screen.dart index 2b85628..b44e21a 100644 --- a/lib/screens/gallery_browsers_screen.dart +++ b/lib/screens/gallery_browsers_screen.dart @@ -84,7 +84,7 @@ class GalleryBrowsersScreen extends StatelessWidget { @override Widget build(BuildContext context) { - _logger.finest('Building'); + _logger.finer('Building'); final service = context .watch>() .activeEntry diff --git a/lib/screens/gallery_screen.dart b/lib/screens/gallery_screen.dart index d002f2f..0dafe95 100644 --- a/lib/screens/gallery_screen.dart +++ b/lib/screens/gallery_screen.dart @@ -24,7 +24,7 @@ class GalleryScreen extends StatelessWidget { @override Widget build(BuildContext context) { - _logger.finest('Building $galleryName'); + _logger.finer('Building $galleryName'); final nss = getIt(); return Scaffold( appBar: StandardAppBar.build(context, galleryName, actions: [ @@ -59,7 +59,7 @@ class _GalleryScreenBody extends StatelessWidget { @override Widget build(BuildContext context) { - _logger.finest('Building'); + _logger.finer('Building'); final service = context .watch>() .activeEntry diff --git a/lib/screens/home.dart b/lib/screens/home.dart index 1f51d00..82fb0d3 100644 --- a/lib/screens/home.dart +++ b/lib/screens/home.dart @@ -29,7 +29,7 @@ class _HomeScreenState extends State { TimelineIdentifiers currentTimeline = TimelineIdentifiers.home(); void updateTimeline(TimelineManager manager) { - _logger.finest('Updating timeline: $currentTimeline'); + _logger.finer('Updating timeline: $currentTimeline'); Future.delayed(const Duration(milliseconds: 100), () async { await manager.updateTimeline( currentTimeline, TimelineRefreshType.refresh); diff --git a/lib/screens/notifications_screen.dart b/lib/screens/notifications_screen.dart index 9bb5b05..23dd3d9 100644 --- a/lib/screens/notifications_screen.dart +++ b/lib/screens/notifications_screen.dart @@ -25,7 +25,7 @@ class NotificationsScreen extends StatelessWidget { @override Widget build(BuildContext context) { - _logger.finest('Building'); + _logger.finer('Building'); final nss = getIt(); final managerResult = context .watch>() diff --git a/lib/screens/search_screen.dart b/lib/screens/search_screen.dart index 47f2c7d..21f2dcd 100644 --- a/lib/screens/search_screen.dart +++ b/lib/screens/search_screen.dart @@ -101,7 +101,7 @@ class _SearchScreenState extends State { @override Widget build(BuildContext context) { - _logger.info('Build'); + _logger.finer('Build'); final nss = getIt(); final profileService = context.watch(); final profile = profileService.currentProfile; @@ -205,7 +205,7 @@ class _SearchScreenState extends State { } Widget buildResultBody(Profile profile) { - _logger.fine('Building search result body with: $searchResult'); + _logger.finer('Building search result body with: $searchResult'); switch (searchType) { case SearchTypes.hashTag: return buildHashtagResultWidget(profile); diff --git a/lib/services/blocks_manager.dart b/lib/services/blocks_manager.dart index a0b2c05..d7f7d51 100644 --- a/lib/services/blocks_manager.dart +++ b/lib/services/blocks_manager.dart @@ -51,7 +51,7 @@ class BlocksManager extends ChangeNotifier { ); }).match( onSuccess: (blockedUser) { - _logger.finest( + _logger.fine( 'Successfully blocked ${blockedUser.name}: ${blockedUser.status}'); final existingIndex = _blocks.indexOf(connection); if (existingIndex < 0) { @@ -71,8 +71,8 @@ class BlocksManager extends ChangeNotifier { } Future unblockConnection(Connection connection) async { - _logger.finest( - 'Attempting to unblock ${connection.name}: ${connection.status}'); + _logger + .fine('Attempting to unblock ${connection.name}: ${connection.status}'); await RelationshipsClient(profile) .unblockConnection(connection) .withResult((blockedUser) { @@ -83,7 +83,7 @@ class BlocksManager extends ChangeNotifier { ); }).match( onSuccess: (unblockedUser) { - _logger.finest( + _logger.fine( 'Successfully unblocked ${unblockedUser.name}: ${unblockedUser.status}'); final existingIndex = _blocks.indexOf(connection); if (existingIndex >= 0) { diff --git a/lib/services/timeline_manager.dart b/lib/services/timeline_manager.dart index 407c101..b82601c 100644 --- a/lib/services/timeline_manager.dart +++ b/lib/services/timeline_manager.dart @@ -53,7 +53,7 @@ class TimelineManager extends ChangeNotifier { } Future _refreshCircleData() async { - _logger.finest('Refreshing member circle data '); + _logger.finer('Refreshing member circle data '); await CirclesClient(profile).getCircles().match( onSuccess: (circles) { circlesRepo.addAllCircles(circles); @@ -217,10 +217,10 @@ class TimelineManager extends ChangeNotifier { FutureResult toggleFavorited( String id, bool newStatus) async { - _logger.finest('Attempting toggling favorite $id to $newStatus'); + _logger.finer('Attempting toggling favorite $id to $newStatus'); final result = await entryManagerService.toggleFavorited(id, newStatus); if (result.isFailure) { - _logger.finest('Error toggling favorite $id: ${result.error}'); + _logger.info('Error toggling favorite $id: ${result.error}'); return result; } diff --git a/lib/utils/network_utils.dart b/lib/utils/network_utils.dart index dcded55..cbfa09c 100644 --- a/lib/utils/network_utils.dart +++ b/lib/utils/network_utils.dart @@ -17,7 +17,7 @@ FutureResult, ExecError> getUrl( Map? headers, Duration? timeout, }) async { - _logger.finer('GET: $url'); + _logger.fine('GET: $url'); final requestHeaders = headers ?? {}; if (usePhpDebugging) { requestHeaders['Cookie'] = 'XDEBUG_SESSION=PHPSTORM;path=/'; @@ -54,7 +54,7 @@ FutureResult postUrl( Map? headers, Duration? timeout, }) async { - _logger.finer('POST: $url \n Body: $body'); + _logger.fine('POST: $url \n Body: $body'); final requestHeaders = headers ?? {}; if (usePhpDebugging) { requestHeaders['Cookie'] = 'XDEBUG_SESSION=PHPSTORM;path=/'; @@ -88,7 +88,7 @@ FutureResult putUrl( Map body, { Map? headers, }) async { - _logger.finer('PUT: $url \n Body: $body'); + _logger.fine('PUT: $url \n Body: $body'); try { final request = http.put( url, @@ -118,7 +118,7 @@ FutureResult deleteUrl( Map body, { Map? headers, }) async { - _logger.finer('DELETE: $url'); + _logger.fine('DELETE: $url'); try { final request = http.delete( url,