From b74b371d2b73aa09e6d36fe3b52cb15c68aabc7d Mon Sep 17 00:00:00 2001 From: Phil Howard Date: Fri, 10 Mar 2023 18:14:57 +0000 Subject: [PATCH] JPEGDEC: Don't pass filename through std::string. The result of GET_STR_DATA_LEN should be null terminated, so converting to a std::string and then using .c_str() is both redundant and need s heap. --- micropython/modules/jpegdec/jpegdec.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/micropython/modules/jpegdec/jpegdec.cpp b/micropython/modules/jpegdec/jpegdec.cpp index 8c3c12a7..7e0eb208 100644 --- a/micropython/modules/jpegdec/jpegdec.cpp +++ b/micropython/modules/jpegdec/jpegdec.cpp @@ -247,10 +247,8 @@ mp_obj_t _JPEG_decode(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args if(mp_obj_is_str_or_bytes(self->file)){ GET_STR_DATA_LEN(self->file, str, str_len); - std::string t((const char*)str); - result = self->jpeg->open( - t.c_str(), + (const char*)str, jpegdec_open_callback, jpegdec_close_callback, jpegdec_read_callback,