From b3f6912327b85ae85980224282556e02ef5c0de2 Mon Sep 17 00:00:00 2001
From: James H Ball <james@ball.sh>
Date: Wed, 8 Jan 2025 11:28:28 +0000
Subject: [PATCH] Add lossless recording toggle button

---
 Source/visualiser/RecordingSettings.cpp |  6 ++++++
 Source/visualiser/RecordingSettings.h   | 16 +++++++++++++---
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/Source/visualiser/RecordingSettings.cpp b/Source/visualiser/RecordingSettings.cpp
index 209817de..c5f78bf5 100644
--- a/Source/visualiser/RecordingSettings.cpp
+++ b/Source/visualiser/RecordingSettings.cpp
@@ -6,6 +6,7 @@
 RecordingSettings::RecordingSettings(RecordingParameters& ps) : parameters(ps) {
 #if SOSCI_FEATURES
     addAndMakeVisible(quality);
+    addAndMakeVisible(losslessVideo);
     addAndMakeVisible(recordAudio);
     addAndMakeVisible(recordVideo);
     addAndMakeVisible(compressionPreset);
@@ -23,6 +24,10 @@ RecordingSettings::RecordingSettings(RecordingParameters& ps) : parameters(ps) {
             recordAudio.setToggleState(true, juce::NotificationType::sendNotification);
         }
     };
+    quality.setEnabled(!losslessVideo.getToggleState());
+    losslessVideo.onClick = [this] {
+        quality.setEnabled(!losslessVideo.getToggleState());
+    };
     compressionPreset.onChange = [this] {
         parameters.compressionPreset = parameters.compressionPresets[compressionPreset.getSelectedId() - 1];
     };
@@ -51,6 +56,7 @@ void RecordingSettings::resized() {
     double rowHeight = 30;
     
 #if SOSCI_FEATURES
+    losslessVideo.setBounds(area.removeFromTop(rowHeight));
     quality.setBounds(area.removeFromTop(rowHeight).expanded(6, 0));
     recordAudio.setBounds(area.removeFromTop(rowHeight));
     recordVideo.setBounds(area.removeFromTop(rowHeight));
diff --git a/Source/visualiser/RecordingSettings.h b/Source/visualiser/RecordingSettings.h
index ac347642..710cb3c9 100644
--- a/Source/visualiser/RecordingSettings.h
+++ b/Source/visualiser/RecordingSettings.h
@@ -27,10 +27,11 @@ public:
 
     EffectParameter qualityParameter = EffectParameter(
         "Video Quality",
-        "Controls the quality of the recording video. 0 is the worst possible quality, and 1 is lossless.",
+        "Controls the quality of the recording video. 0 is the worst possible quality, and 1 is almost lossless.",
         "brightness",
         VERSION_HINT, 0.7, 0.0, 1.0
     );
+    BooleanParameter losslessVideo = BooleanParameter("Lossless Video", "losslessVideo", VERSION_HINT, false, "Record video in a lossless format. WARNING: This is not supported by all media players.");
     Effect qualityEffect = Effect(&qualityParameter);
 
     BooleanParameter recordAudio = BooleanParameter("Record Audio", "recordAudio", VERSION_HINT, true, "Record audio along with the video.");
@@ -40,6 +41,7 @@ public:
 
     void save(juce::XmlElement* xml) {
         auto settingsXml = xml->createNewChildElement("recordingSettings");
+        losslessVideo.save(settingsXml->createNewChildElement("losslessVideo"));
         recordAudio.save(settingsXml->createNewChildElement("recordAudio"));
         recordVideo.save(settingsXml->createNewChildElement("recordVideo"));
         settingsXml->setAttribute("compressionPreset", compressionPreset);
@@ -51,6 +53,9 @@ public:
     // opt to not change any values if not found
     void load(juce::XmlElement* xml) {
         if (auto* settingsXml = xml->getChildByName("recordingSettings")) {
+            if (auto* losslessVideoXml = settingsXml->getChildByName("losslessVideo")) {
+                losslessVideo.load(losslessVideoXml);
+            }
             if (auto* recordAudioXml = settingsXml->getChildByName("recordAudio")) {
                 recordAudio.load(recordAudioXml);
             }
@@ -77,9 +82,13 @@ public:
     void resized() override;
 
     int getCRF() {
+        if (parameters.losslessVideo.getBoolValue()) {
+            return 0;
+        }
         double quality = juce::jlimit(0.0, 1.0, parameters.qualityEffect.getValue());
-        // mapping to 0-51 for ffmpeg's crf value
-        return 51 * (1.0 - quality) ;
+        // mapping to 1-51 for ffmpeg's crf value (ignoring 0 as this is lossless and
+        // not supported by all media players)
+        return 50 * (1.0 - quality) + 1;
     }
 
     bool recordingVideo() {
@@ -99,6 +108,7 @@ public:
 private:
     EffectComponent quality{parameters.qualityEffect};
 
+    jux::SwitchButton losslessVideo{&parameters.losslessVideo};
     jux::SwitchButton recordAudio{&parameters.recordAudio};
     jux::SwitchButton recordVideo{&parameters.recordVideo};