Workflow - use insecure curl when can (#838)

Turned out that some update jobs failed due to

```
{
  "message": "Bad credentials",
  "documentation_url": "https://developer.github.com/v3"
}
```

This is probably due to credentials expiring (long workflow startup?),
or some internal github issue.

For now, removing authenticated `curl` calls because most
of them can be done anonymously, and keeping them only when needed.
pull/757/head^2
Yuri Astrakhan 2020-04-28 23:38:06 -04:00 zatwierdzone przez GitHub
rodzic d5569fb679
commit 5f277b5023
Nie znaleziono w bazie danych klucza dla tego podpisu
ID klucza GPG: 4AEE18F83AFDEB23
1 zmienionych plików z 9 dodań i 4 usunięć

Wyświetl plik

@ -44,7 +44,6 @@ jobs:
crl() {
curl --silent --show-error --location --retry 1 "${@:2}" \
-H "Accept: application/vnd.github.antiope-preview+json, application/vnd.github.v3+json" \
-H "authorization: Bearer $GITHUB_TOKEN" \
"$1"
}
@ -183,7 +182,7 @@ jobs:
fi
echo "Downloading artifact $ARTIFACT_URL (assuming single text file per artifact)..."
if ! MESSAGE="$(crl "$ARTIFACT_URL" | gunzip)"; then
if ! MESSAGE="$(crl "$ARTIFACT_URL" -H "authorization: Bearer $GITHUB_TOKEN" | gunzip)"; then
echo "Unable to download or parse message from artifact '$MSG_ARTIFACT_NAME' in workflow $RUN_ID (PR #$PR_NUMBER), skipping..."
continue
fi
@ -211,7 +210,10 @@ jobs:
if [ -z "$OLD_COMMENT" ]; then
COMMENT_URL="$(crl "$GITHUB_API/issues/$PR_NUMBER/comments" \
-X POST -H "Content-Type: application/json" --data "$MESSAGE_BODY" \
-X POST \
-H "Content-Type: application/json" \
-H "authorization: Bearer $GITHUB_TOKEN" \
--data "$MESSAGE_BODY" \
| jq -r '.html_url' )"
COMMENT_INFO="New comment $COMMENT_URL was created"
else
@ -228,7 +230,10 @@ jobs:
fi
crl "$COMMENT_URL" \
-X PATCH -H "Content-Type: application/json" --data "$MESSAGE_BODY" \
-X PATCH \
-H "authorization: Bearer $GITHUB_TOKEN" \
-H "Content-Type: application/json" \
--data "$MESSAGE_BODY" \
| jq -r '("Updated existing comment " + .html_url)'
COMMENT_INFO="Existing comment $COMMENT_URL was updated"