mirror
/
ogn-live
kopia lustrzana https://github.com/glidernet/ogn-live
1
0
Forkuj 0
Kod Zgłoszenia Projekty Wydania Wiki Aktywność

Fixed SQL injection vulnerabilities by using PDO statements. 

Not tested as I do not have a database schema and am too lazy to reverse engineer it.
pull/11/head
dbursem 2015-02-06 01:01:05 +01:00
rodzic db210f3829
commit 6c7374c870
3 zmienionych plików z 59 dodań i 68 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

2
.gitignore vendored 100644
Wyświetl plik

@ -0,0 +1,2 @@
.idea
config.php

95
index.php
Wyświetl plik

@ -1,61 +1,64 @@
<?php
$link="";
require('sql.php');
ouvrebase();
if (isset($_GET['rec'])) { $recc="'&r=".$_GET['rec']."'"; $reqc=" AND rec='".$_GET['rec']."'"; } else { $recc = "\"\""; $reqc=""; }
if (isset($_GET['pw'])) { $parc="'&p=".$_GET['pw']."'"; } else { $parc = "\"\""; }
$q="select * from live where tim > 0";
if (isset($_GET['rec']))
{
$recc="'&r=".$_GET['rec']."'";
$q .=" AND rec=?";
$params[] = $_GET['rec'];
}
else
{
$recc = "\"\"";
}
$req="select * from live where tim > 0";
$req.=$reqc;
if (isset($_GET['pw']))
{
$parc="'&p=".$_GET['pw']."'";
}
else
{
$parc = "\"\"";
}
$latmax=$latmin=$lonmax=$lonmin=0;
if (!$result=@mysql_query ($req))
{
echo "<BR><BR><CENTER>Request error $req</CENTER><BR><BR>";
@mysql_close($link);
exit();
}
$stmt = $dbh->prepare($q);
$stmt->execute($params);
if (@mysql_num_rows($result)==0)
{
$latmax=60;
$latmin=35;
$lonmax=30;
$lonmin=-10;
$lon=2;
$lat=45;
}
if ($stmt->columnCount() == 0)
{
$latmax=60;
$latmin=35;
$lonmax=30;
$lonmin=-10;
$lon=2;
$lat=45;
}
else
{
$aa=0;
while($ligne = @mysql_fetch_array($result))
{
$aa=0;
while($ligne = $stmt->fetch(PDO::FETCH_ASSOC))
{
extract($ligne);
if ($aa==0)
{
$latmax=$latmin=$lat;
$lonmax=$lonmin=$lon;
$aa=1;
}
else
{
if ($lat>$latmax) $latmax=$lat;
if ($lat<$latmin) $latmin=$lat;
if ($lon>$lonmax) $lonmax=$lon;
if ($lon<$lonmin) $lonmin=$lon;
}
extract($ligne);
if ($aa==0)
{
$latmax=$latmin=$lat;
$lonmax=$lonmin=$lon;
$aa=1;
}
else
{
if ($lat>$latmax) $latmax=$lat;
if ($lat<$latmin) $latmin=$lat;
if ($lon>$lonmax) $lonmax=$lon;
if ($lon<$lonmin) $lonmin=$lon;
}
}
}
}
echo "<!DOCTYPE html>
@ -123,5 +126,3 @@ catch(e) {
</body>
</html>";
@mysql_close($link);
?>

30
sql.php
Wyświetl plik

@ -1,23 +1,11 @@
<?php
function ouvrebase()
{
// **************** Connexion et ouverture de la base ************************
global $link;
//if (!($link = @mysql_connect( ))) // en local
if (!($link = @mysql_connect("****hostname****", "****username****", "****password****" ))) //
{
echo "<BR><BR><CENTER>Connection not possible</CENTER><BR><BR>";
@mysql_close($link);
exit();
}
include 'config.php';
if (!(@mysql_select_db ("****databasename****",$link)))
{
echo "<BR><BR><CENTER>Database access not possible</CENTER><BR><BR>";
@mysql_close($link);
exit();
}
// ***************************************************************************
}
?>
try
{
$dbh = new PDO($cfg['db_type'].':host='.$cfg['db_host'].';dbname='.$cfg['db_name'], $cfg['db_user'], $cfg['db_pass']);
$dbh->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
}
catch (PDOException $e) {
echo 'Connection failed: ' . $e->getMessage();
}