Closes#500
NanoVNA-saver crashes per below when getPlotable returns a float.
getPlotable is always followed by a call to drawLine(self, int, int,
int, int), so it needs to return ints.
Cast getPlotable return values to int in all cases.
Traceback (most recent call last):
File "/home/blinken/co/nanovna-saver/NanoVNASaver/Charts/Frequency.py", line 447, in paintEvent
self.drawValues(qp)
File "/home/blinken/co/nanovna-saver/NanoVNASaver/Charts/VSWR.py", line 144, in drawValues
self.drawData(qp, self.data, Chart.color.sweep)
File "/home/blinken/co/nanovna-saver/NanoVNASaver/Charts/Frequency.py", line 641, in drawData
qp.drawLine(prevx, prevy, new_x, new_y)
TypeError: arguments did not match any overloaded call:
drawLine(self, QLineF): argument 1 has unexpected type 'int'
drawLine(self, QLine): argument 1 has unexpected type 'int'
drawLine(self, int, int, int, int): argument 3 has unexpected type 'numpy.float64'
drawLine(self, QPoint, QPoint): argument 1 has unexpected type 'int'
drawLine(self, Union[QPointF, QPoint], Union[QPointF, QPoint]): argument 1 has unexpected type 'int'
Aborted
The comparison operators (<, >, etc.) are not translated 1:1 to
customisation methods (__lt__, __gt__, ...) in Python. Instead the
type of the operands plays a role in determining on which of the two
sides the customisation method is invoked (see Python Language
Reference section 3.3.1 [1]). This means 'a > b' can end up invoking
b.__lt__(a) rather than a.__gt__(b).
This behaviour can causes infinite recursion in Version.__lt__():
2022-03-07 13:47:52,087 - NanoVNASaver.Hardware.NanoVNA_V2 - ERROR - Timeout reading version registers
Traceback (most recent call last):
File "/home/sascha/nanovna-saver/NanoVNASaver/Controls/SerialControl.py", line 73, in serialButtonClick
self.connect_device()
File "/home/sascha/nanovna-saver/NanoVNASaver/Controls/SerialControl.py", line 93, in connect_device
self.app.vna = get_VNA(self.interface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/Hardware.py", line 101, in get_VNA
return NAME2DEVICE[iface.comment](iface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/NanoVNA_V2.py", line 76, in __init__
super().__init__(iface)
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/VNA.py", line 71, in __init__
self.read_features()
File "/home/sascha/nanovna-saver/NanoVNASaver/Hardware/NanoVNA_V2.py", line 107, in read_features
if self.board_revision >= Version("2.0.4"):
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 63, in __le__
return self < other or self == other
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
File "/home/sascha/nanovna-saver/NanoVNASaver/Version.py", line 57, in __lt__
return other > self
[Previous line repeated 491 more times]
RecursionError: maximum recursion depth exceeded in comparison
Fix it by explicitly invoking the customisation methods we expect.
[1] https://docs.python.org/3/reference/datamodel.html#object.__lt__
mss