From 7437d26260f7c80d150d86cb81b6569b47876a78 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Holger=20M=C3=BCller?= <zarath@gmx.de>
Date: Sun, 14 Jun 2020 09:19:28 +0200
Subject: [PATCH] Added some TODOs

---
 NanoVNASaver/Hardware/VNA.py | 12 +++++++-----
 nanovna-saver.py             |  2 +-
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/NanoVNASaver/Hardware/VNA.py b/NanoVNASaver/Hardware/VNA.py
index a80d7b1..5e8c83d 100644
--- a/NanoVNASaver/Hardware/VNA.py
+++ b/NanoVNASaver/Hardware/VNA.py
@@ -47,14 +47,15 @@ class VNA:
 
         return self.features
 
-    def readFrequencies(self) -> List[str]:
-        pass
+    # TODO: check return types
+    def readFrequencies(self) -> List[int]:
+        return []
 
     def readValues11(self) -> List[str]:
-        pass
+        return []
 
     def readValues21(self) -> List[str]:
-        pass
+        return []
 
     def resetSweep(self, start: int, stop: int):
         pass
@@ -173,7 +174,8 @@ class VNA:
     def setSweep(self, start, stop):
         self.writeSerial("sweep " + str(start) + " " + str(stop) + " " + str(self.datapoints))
 
-
+# TODO: should be dropped and the serial part should be a connection class which handles
+#       unconnected devices
 class InvalidVNA(VNA):
     name = "Invalid"
 
diff --git a/nanovna-saver.py b/nanovna-saver.py
index 62c4930..9012b88 100644
--- a/nanovna-saver.py
+++ b/nanovna-saver.py
@@ -17,4 +17,4 @@
 from NanoVNASaver.__main__ import main
 
 if __name__ == '__main__':
-    main()
\ No newline at end of file
+    main()