From d725e6622c5512a0ce97f46bd580d08b51fcd2a8 Mon Sep 17 00:00:00 2001 From: Atul Varma Date: Sun, 6 Jun 2021 17:53:43 -0400 Subject: [PATCH] Add comment linking to #140. --- lib/svg-symbol.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/svg-symbol.tsx b/lib/svg-symbol.tsx index 266313a..84a5fc8 100644 --- a/lib/svg-symbol.tsx +++ b/lib/svg-symbol.tsx @@ -161,6 +161,13 @@ function getFill( if (fill) { if (URL_FUNC_TO_ANCHOR_RE.test(fill)) { if (ctx.disableGradients) { + // Note that we could actually interpret the gradient here + // and use whichever color (fill or stroke) is most dominant + // in it, but at the time of this writing, it's always the + // fill color, so we're just using that. For more details, + // see: + // + // https://github.com/mysticsymbolic/mysticsymbolic.github.io/issues/140 fill = ctx.fill; } else { fill = uidMap.rewriteUrl(fill);