From 4e8b4960e979c874bbb2f79e2348e793da2cf468 Mon Sep 17 00:00:00 2001 From: Andrey Date: Wed, 28 Feb 2024 18:05:42 +0200 Subject: [PATCH] Change query params check. --- engineapi/engineapi/actions.py | 5 ++--- engineapi/engineapi/routes/leaderboard.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/engineapi/engineapi/actions.py b/engineapi/engineapi/actions.py index a19d764a..bc0c6d74 100644 --- a/engineapi/engineapi/actions.py +++ b/engineapi/engineapi/actions.py @@ -1288,8 +1288,8 @@ def get_leaderboard_positions( leaderboard_id: uuid.UUID, limit: int, offset: int, + poitns_data: Dict[str, str], version_number: Optional[int] = None, - poitns_data: Optional[Dict[str, str]] = None, ) -> List[Row[Tuple[uuid.UUID, str, int, str, int]]]: """ Get the leaderboard positions @@ -1325,7 +1325,7 @@ def get_leaderboard_positions( .filter(LeaderboardVersion.version_number == latest_version) ) - if poitns_data: + if len(poitns_data) > 0: query = query.filter( or_( @@ -1336,7 +1336,6 @@ def get_leaderboard_positions( ) ) - if limit: query = query.limit(limit) diff --git a/engineapi/engineapi/routes/leaderboard.py b/engineapi/engineapi/routes/leaderboard.py index b41b2c04..59964492 100644 --- a/engineapi/engineapi/routes/leaderboard.py +++ b/engineapi/engineapi/routes/leaderboard.py @@ -137,7 +137,7 @@ async def leaderboard( raise EngineHTTPException(status_code=500, detail="Internal server error") leaderboard_positions = actions.get_leaderboard_positions( - db_session, leaderboard.id, limit, offset, version, points_data + db_session, leaderboard.id, limit, offset, points_data, version ) result = [