From c5dbbf71c0021e03bf39aeedf31561be81b61978 Mon Sep 17 00:00:00 2001 From: robert-hh Date: Thu, 9 Dec 2021 08:44:26 +0100 Subject: [PATCH] mimxrt: Use -Og instead of -O0 for DEBUG builds. Thanks for the hint, Damien. The DEBUG build got very large recently. The major difference is, that inline function are now inlined and not included as a function. That's good and maybe bad. The good thing is, that the code speed si now close to the final code. It could be worse in single step debugging. I'll see. Setting this option caused a new warning and a formatting error to pop up at different places. Fixed as well. --- ports/mimxrt/Makefile | 2 +- ports/mimxrt/hal/phy/device/phydp83848/fsl_phydp83848.c | 2 +- ports/mimxrt/mimxrt_flash.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ports/mimxrt/Makefile b/ports/mimxrt/Makefile index 574aebb4cd..680e87cac4 100644 --- a/ports/mimxrt/Makefile +++ b/ports/mimxrt/Makefile @@ -125,7 +125,7 @@ LIBS = $(shell $(CC) $(CFLAGS) -print-libgcc-file-name) # Tune for Debugging or Optimization ifeq ($(DEBUG),1) -CFLAGS += -O0 -ggdb +CFLAGS += -Og -ggdb LDFLAGS += --gc-sections CFLAGS += -fdata-sections -ffunction-sections else diff --git a/ports/mimxrt/hal/phy/device/phydp83848/fsl_phydp83848.c b/ports/mimxrt/hal/phy/device/phydp83848/fsl_phydp83848.c index 0ef618d421..07ce6d1f7f 100644 --- a/ports/mimxrt/hal/phy/device/phydp83848/fsl_phydp83848.c +++ b/ports/mimxrt/hal/phy/device/phydp83848/fsl_phydp83848.c @@ -25,7 +25,7 @@ #define PHY_PHYSTS_LINK_MASK 0x0001U /*!< The PHY link up mask. */ #define PHY_RMII_MODE 0x20 -#define PHY_RMII_REV1_0 0x10 +#define PHY_RMII_REV1_0 0x10 /*! @brief Defines the timeout macro. */ #define PHY_READID_TIMEOUT_COUNT 1000U diff --git a/ports/mimxrt/mimxrt_flash.c b/ports/mimxrt/mimxrt_flash.c index 25a11ab7ca..27ab987ed1 100644 --- a/ports/mimxrt/mimxrt_flash.c +++ b/ports/mimxrt/mimxrt_flash.c @@ -79,7 +79,7 @@ status_t flash_erase_block(uint32_t erase_addr) { // the vfs driver takes care for erasing the sector if required status_t flash_write_block(uint32_t dest_addr, const uint8_t *src, uint32_t length) __attribute__((section(".ram_functions"))); status_t flash_write_block(uint32_t dest_addr, const uint8_t *src, uint32_t length) { - status_t status; + status_t status = 0; uint32_t size; uint32_t next_addr;