From 2e101a8e44b7f1bff75cc06a0597c572a8d8d152 Mon Sep 17 00:00:00 2001 From: Elias Wimmer Date: Sun, 10 Dec 2023 23:25:14 +0100 Subject: [PATCH] extmod/modonewire: Improve write timings for better reliability. When using long cables for sensors on onewire e.g. ds18b20, the current default timings are too optimistic, leading to bus failures and CRC errors. Stable results are achieved with the timings given by https://www.analog.com/en/technical-articles/1wire-communication-through-software.html --- extmod/modonewire.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extmod/modonewire.c b/extmod/modonewire.c index dbd519776e..8444181810 100644 --- a/extmod/modonewire.c +++ b/extmod/modonewire.c @@ -41,8 +41,8 @@ #define TIMING_READ1 (6) #define TIMING_READ2 (9) #define TIMING_READ3 (55) -#define TIMING_WRITE1 (10) -#define TIMING_WRITE2 (50) +#define TIMING_WRITE1 (6) +#define TIMING_WRITE2 (54) #define TIMING_WRITE3 (10) STATIC int onewire_bus_reset(mp_hal_pin_obj_t pin) {