diff --git a/proto b/proto index 9c16118e5..3252ed0f1 160000 --- a/proto +++ b/proto @@ -1 +1 @@ -Subproject commit 9c16118e59e7318cd8cb92199511c19232939f5f +Subproject commit 3252ed0f1357d55233f2d5cb50acf20dbb9160ed diff --git a/src/mesh/MeshPlugin.cpp b/src/mesh/MeshPlugin.cpp index b3a12fc83..45c7bcf18 100644 --- a/src/mesh/MeshPlugin.cpp +++ b/src/mesh/MeshPlugin.cpp @@ -142,6 +142,10 @@ void MeshPlugin::callPlugins(const MeshPacket &mp) } else { // No one wanted to reply to this requst, tell the requster that happened DEBUG_MSG("No one responded, send a nak\n"); + + // SECURITY NOTE! I considered sending back a different error code if we didn't find the psk (i.e. !isDecoded) + // but opted NOT TO. Because it is not a good idea to let remote nodes 'probe' to find out which PSKs were "good" vs + // bad. routingPlugin->sendAckNak(Routing_Error_NO_RESPONSE, getFrom(&mp), mp.id, mp.channel); } }