From 26035960320e6e11ab41a4d004ac87cc55a5fb62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20=27rysiek=27=20Wo=C5=BAniak?= Date: Wed, 17 Nov 2021 13:57:47 +0000 Subject: [PATCH] updated tests regarding problematic Request() init fields (ref. #23) --- __tests__/service-worker.test.js | 14 ++++++++------ service-worker.js | 1 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/__tests__/service-worker.test.js b/__tests__/service-worker.test.js index 472bd7b..9318b20 100644 --- a/__tests__/service-worker.test.js +++ b/__tests__/service-worker.test.js @@ -217,9 +217,10 @@ describe("service-worker", () => { var initTest = { method: "GET", - headers: new Headers({"x-stub": "STUB"}), - mode: "mode-stub", - credentials: "credentials-stub", + // TODO: ref. https://gitlab.com/rysiekpl/libresilient/-/issues/23 + //headers: new Headers({"x-stub": "STUB"}), + //mode: "mode-stub", + //credentials: "credentials-stub", cache: "cache-stub", referrer: "referrer-stub", // these are not implemented by service-worker-mock @@ -727,9 +728,10 @@ describe("service-worker", () => { var initTest = { method: "GET", - headers: new Headers({"x-stub": "STUB"}), - mode: "mode-stub", - credentials: "credentials-stub", + // TODO: ref. https://gitlab.com/rysiekpl/libresilient/-/issues/23 + //headers: new Headers({"x-stub": "STUB"}), + //mode: "mode-stub", + //credentials: "credentials-stub", cache: "cache-stub", referrer: "referrer-stub", // these are not implemented by service-worker-mock diff --git a/service-worker.js b/service-worker.js index c9bfe51..6afa05c 100644 --- a/service-worker.js +++ b/service-worker.js @@ -418,6 +418,7 @@ let LibResilientResourceInfo = class { let initFromRequest = (req) => { return { method: req.method, + // TODO: ref. https://gitlab.com/rysiekpl/libresilient/-/issues/23 //headers: req.headers, TODO: commented out: https://stackoverflow.com/questions/32500073/request-header-field-access-control-allow-headers-is-not-allowed-by-itself-in-pr //mode: req.mode, TODO: commented out because mode: navigate is haram in service worker, it seems //credentials: req.credentials, TODO: commented out because credentials: "include" is haram if the Access-Control-Allow-Origin header is '*'