stroke: filter invalid paths in clipped path (#3989)

README.md

@@ -14,6 +14,11 @@ Want to learn more?
 * Watch some [videos](https://inkstitch.org/tutorials/video/) of Ink/Stitch in action
 * ...and lots more on our [website](https://inkstitch.org)
 
+Need help?
+
+* Contact us via the [Inkscape Forum](https://inkscape.org/forums/embroidery/)
+* Join our [chat channel](https://chat.inkscape.org/channel/inkstitch)
+
 # Background and Philosophy
 
 _by @lexelby, an Ink/Stitch programmer_

TODO

@@ -1,17 +0,0 @@
- * pattern fill
-    * turns out this is a lot easier than I thought it was
-    * just like normal fill except the stitch locations in each row are chosen to make a pattern
-    * can do this by intersecting the pattern with the shape instead of just a generic grating
- * curved fill
-   * use radial fill in inkscape to define center and starting angle
-   * the rows of stitches radiate out from a center point
-     * otherwise it's just like normal fill
- * start/end points for fills
-   * rotation center might work for one of them, but what else can I use in inkscape's UI?
- * keep stitch plan objects and just update the ones that change
-   * use md5sum of <path> objects to see what's changed
-   * keep stitch plans in a layer above everything else
-   * set stitch plans to "noninteractive" so you can click through them to the paths
-   * this will make it work more like a "real" embroidery program
-   * separate 'export embroidery file' command
- * add option for connection to next patch (jump, trim, or running stitch)

icons/inx/transform.svg

@@ -0,0 +1,114 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+   xml:space="preserve"
+   width="99.999901mm"
+   height="100mm"
+   version="1.1"
+   style="clip-rule:evenodd;fill-rule:evenodd;image-rendering:optimizeQuality;shape-rendering:geometricPrecision;text-rendering:geometricPrecision"
+   viewBox="0 0 15109 15109.485"
+   id="svg5"
+   sodipodi:docname="transform.svg"
+   inkscape:version="1.4.2 (ebf0e940d0, 2025-05-08)"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns:inkstitch="http://inkstitch.org/namespace"><sodipodi:namedview
+   id="namedview5"
+   pagecolor="#ffffff"
+   bordercolor="#000000"
+   borderopacity="0.25"
+   inkscape:showpageshadow="2"
+   inkscape:pageopacity="0.0"
+   inkscape:pagecheckerboard="0"
+   inkscape:deskcolor="#d1d1d1"
+   inkscape:document-units="mm"
+   inkscape:zoom="0.50485935"
+   inkscape:cx="244.62259"
+   inkscape:cy="118.84498"
+   inkscape:window-width="1920"
+   inkscape:window-height="1131"
+   inkscape:window-x="0"
+   inkscape:window-y="0"
+   inkscape:window-maximized="1"
+   inkscape:current-layer="Layer_x0020_1"
+   showgrid="false" /><metadata
+   id="metadata2"><inkstitch:min_stitch_len_mm>0.3</inkstitch:min_stitch_len_mm><inkstitch:collapse_len_mm>10.0</inkstitch:collapse_len_mm><inkstitch:inkstitch_svg_version>3</inkstitch:inkstitch_svg_version></metadata><defs
+   id="defs1"><symbol
+   id="inkstitch_ignore_layer"
+   transform="scale(0.25, 0.25)"
+   style="opacity:0.7">
+      <title
+   id="title9694">Ignore entire layer when generating stitch plan</title>
+      <path
+   inkscape:connector-curvature="0"
+   style="opacity:1;vector-effect:none;fill:#fafafa;fill-opacity:1;fill-rule:evenodd;stroke:#ff0000;stroke-width:1.06501234;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:3.19503705, 3.19503705;stroke-dashoffset:0;stroke-opacity:1"
+   d="M 9.2465269,-4.9265995e-6 C 9.246525,5.1067241 5.1067028,9.2465451 -2.615882e-5,9.2465451 -5.1067554,9.2465451 -9.2465782,5.1067241 -9.2465801,-4.9265995e-6 -9.24658,-2.4523429 -8.2723922,-4.8042399 -6.538327,-6.5383059 c 1.7340653,-1.734065 4.0859624,-2.708252 6.53830084118,-2.708252 5.10673015882,0 9.24655285882,4.139823 9.24655305882,9.2465529734005 0,0 0,0 0,0"
+   id="inkstitch_path25368-7" />
+      <path
+   sodipodi:nodetypes="ccccc"
+   inkscape:connector-curvature="0"
+   style="color:#000000;fill:#d5d5d5;fill-opacity:1;fill-rule:evenodd;stroke:#5a5a5a;stroke-width:0.63330007;stroke-linecap:square;stroke-linejoin:round;stroke-miterlimit:0;stroke-opacity:1"
+   d="M 4,4.452769 1.46667,1.286102 H -5.5 l 2.53333,3.166667 z"
+   id="use5800" />
+      <path
+   sodipodi:nodetypes="ccccc"
+   inkscape:connector-curvature="0"
+   style="color:#000000;opacity:0.5;fill:#d5d5d5;fill-opacity:1;fill-rule:evenodd;stroke:#858585;stroke-width:0.63339424;stroke-linecap:square;stroke-linejoin:round;stroke-miterlimit:0;stroke-opacity:1"
+   d="M 4,2.552769 1.46667,-0.613898 H -5.5 l 2.53333,3.166667 z"
+   id="use5864" />
+      <g
+   id="g5771">
+        <path
+   sodipodi:nodetypes="ccccccccc"
+   inkscape:connector-curvature="0"
+   style="fill:#aa0000;fill-rule:evenodd;stroke:#aa0000;stroke-width:1px"
+   d="m -1.0666699,-5.0472339 h 4.4333333 l 0.6333333,0.6333333 V 0.01943274 L 3.3666634,0.65276607 H -1.0666699 L -1.7000032,0.01943274 V -4.4139006 Z"
+   id="path8011" />
+        <path
+   inkscape:connector-curvature="0"
+   id="path8023"
+   d="m -0.43333658,-3.8755672 c 0,0 3.16666668,3.16666661 3.16666668,3.16666661"
+   style="fill:none;stroke:#ffffff;stroke-width:1.70000005" />
+        <path
+   inkscape:connector-curvature="0"
+   id="path8025"
+   d="m 2.7333301,-3.8755672 c 0,0 -3.16666668,3.16666661 -3.16666668,3.16666661"
+   style="fill:none;stroke:#ffffff;stroke-width:1.79999995;stroke-linejoin:round" />
+      </g>
+    </symbol>
+    </defs>
+ <g
+   id="Layer_x0020_1"
+   inkscape:label="Layer 1"
+   inkscape:groupmode="layer">
+  <g
+   id="g6"
+   transform="matrix(3.72213,0,0,3.72213,-40581.951,-41363.2)"
+   style="display:inline;opacity:1;stroke-width:0.268663"><path
+     class="fil1"
+     d="M 14667.311,12672.251 C 14670.674,12694.45 14689.847,12711.269 14712.719,12711.269 V 12711.269 C 14737.947,12711.269 14758.801,12690.75 14758.801,12665.186 V 12616.75 C 14758.801,12604.305 14764.856,12593.877 14775.283,12587.15 14786.047,12580.759 14798.492,12580.423 14809.256,12586.478 14837.174,12600.941 14855.674,12628.523 14855.674,12664.514 V 13602.296 C 14855.674,13651.741 14814.974,13692.441 14765.528,13692.441 H 14667.311 V 13841.45 C 14667.311,14399.478 14210.865,14855.923 13652.837,14855.923 H 12236.746 C 11678.719,14855.923 11221.937,14399.478 11221.937,13841.45 V 13706.232 H 11125.737 C 11074.946,13706.232 11033.573,13664.86 11033.573,13614.405 V 12679.986 C 11033.573,12629.532 11074.946,12588.159 11125.737,12588.159 H 11221.937 V 12425.359 C 11221.937,11867.331 11678.719,11410.886 12236.746,11410.886 H 13652.837 C 14210.865,11410.886 14667.311,11867.331 14667.311,12425.359 Z M 11150.292,13239.359 H 11186.282 C 11200.746,13239.359 11213.528,13246.423 11221.937,13256.85 V 13314.032 C 11213.528,13324.796 11200.746,13331.523 11186.282,13331.523 H 11150.292 C 11125.065,13331.523 11104.546,13310.669 11104.546,13285.441 V 13285.441 C 11104.546,13260.214 11125.065,13239.359 11150.292,13239.359 Z M 11168.455,13478.177 C 11193.683,13478.177 11214.201,13498.696 11214.201,13523.923 11214.201,13549.486 11193.683,13570.005 11168.455,13570.005 11142.892,13570.005 11122.374,13549.486 11122.374,13523.923 11122.374,13498.696 11142.892,13478.177 11168.455,13478.177 Z M 14705.319,13239.359 H 14741.311 C 14766.538,13239.359 14787.392,13260.214 14787.392,13285.441 V 13285.441 C 14787.392,13310.669 14766.538,13331.523 14741.311,13331.523 H 14705.319 C 14689.51,13331.523 14675.719,13323.45 14667.311,13311.005 V 13259.877 C 14675.719,13247.769 14689.51,13239.359 14705.319,13239.359 Z M 14723.483,13478.514 C 14748.711,13478.514 14768.892,13498.696 14768.892,13523.923 14768.892,13549.15 14748.711,13569.669 14723.483,13569.669 14698.256,13569.669 14677.738,13549.15 14677.738,13523.923 14677.738,13498.696 14698.256,13478.514 14723.483,13478.514 Z M 12236.746,11583.104 C 11773.91,11583.104 11394.492,11962.523 11394.492,12425.359 V 13841.45 C 11394.492,14304.287 11773.91,14683.706 12236.746,14683.706 H 13652.837 C 14115.674,14683.706 14495.093,14304.287 14495.093,13841.45 V 12425.359 C 14495.093,11962.523 14115.674,11583.104 13652.837,11583.104 Z"
+     id="path1"
+     style="fill:#003399;stroke:none;stroke-width:10.7404;stroke-dasharray:none"
+     sodipodi:nodetypes="cssssccssscsssscsssscsssscssccssssssssssssssssccsssssssssssssss" /></g>
+ <g
+   id="g7"
+   transform="translate(36.865216,893.56746)"><path
+     id="path5"
+     style="fill:none;stroke:#ff0000;stroke-width:226.642;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none;stroke-opacity:1"
+     d="M 4819.789,5380.7469 C 4839.7574,2138 9544.3315,1454.7268 10204.82,4760.6013"
+     sodipodi:nodetypes="cc" /><path
+     style="clip-rule:evenodd;fill:#ff0000;fill-opacity:1;fill-rule:evenodd;stroke:none;stroke-width:226.642;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none;image-rendering:optimizeQuality;shape-rendering:geometricPrecision;text-rendering:geometricPrecision"
+     d="M 9452.4483,4147.3029 C 9452.4483,4147.3029 10095.825,4563.0232 10669.915,3889.9525 10580.832,4503.6347 10392.768,5701.3046 10392.768,5701.3046 Z"
+     id="path6" /></g><g
+   id="g8"
+   transform="translate(36.865216,893.56746)"><path
+     id="object4619"
+     style="clip-rule:evenodd;fill:none;fill-rule:evenodd;stroke:#000000;stroke-width:151.095;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none;image-rendering:optimizeQuality;shape-rendering:geometricPrecision;text-rendering:geometricPrecision"
+     d="M 2954.0207,6799.3397 C 2954.2415,6874.8877 2954.4624,6950.4354 2954.6832,7025.9835 2954.4624,6950.4354 2954.2415,6874.8877 2954.0207,6799.3397 2957.5537,8007.9784 2961.0867,9216.6168 2964.6198,10425.255 4505.2016,10426.183 6045.7871,10425.39 7586.3703,10425.654 7412.3622,10274.619 7238.3537,10123.585 7064.3452,9972.5508 5697.3288,9972.147 4330.3124,9972.4672 2963.2959,9972.3649 2962.8542,9821.2684 2962.4126,9670.1722 2961.9709,9519.0757 4155.2776,9519.0757 5348.5846,9519.0757 6541.8915,9519.0757 6367.883,9368.0411 6193.8749,9217.0066 6019.8664,9065.972 5000.1266,9065.5422 3980.386,9065.9072 2960.6459,9065.7861 2960.2046,8914.8227 2959.7633,8763.8589 2959.322,8612.8955 3805.3508,8611.9724 4651.3828,8612.7575 5497.4132,8612.4969 5323.4047,8461.4623 5149.3962,8310.4277 4975.3877,8159.3932 4302.9237,8158.9834 3630.4598,8159.3144 2957.9958,8159.2077 2957.5541,8008.1111 2957.1125,7857.015 2956.6708,7705.9185 3455.4254,7705.9185 3954.1799,7705.9185 4452.9344,7705.9185 4278.926,7554.8839 4104.9175,7403.8493 3930.9091,7252.8148 3605.7214,7252.5305 3280.5335,7252.6537 2955.3457,7252.6289 2954.5187,6969.719 2953.6918,6686.8091 2952.8648,6403.8992 3104.6571,6535.6506 3256.4494,6667.4024 3408.2417,6799.1538 3256.8347,6799.2165 3105.4277,6799.3621 2954.0207,6799.3397 2982.634,6799.3397 3045.4885,6799.3397 3053.5448,6799.3397 3020.3701,6799.3397 2987.1954,6799.3397 2954.0207,6799.3397 Z"
+     inkstitch:stroke_method="manual_stitch" /><path
+     id="path4"
+     style="clip-rule:evenodd;fill:none;fill-rule:evenodd;stroke:#000000;stroke-width:151.095;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none;image-rendering:optimizeQuality;shape-rendering:geometricPrecision;text-rendering:geometricPrecision"
+     d="M 12162.072,6099.207 C 12086.524,6099.4278 12010.977,6099.6487 11935.428,6099.8695 12010.977,6099.6487 12086.524,6099.4278 12162.072,6099.207 10953.434,6102.74 9744.7951,6106.273 8536.1567,6109.8061 8535.2287,7650.3879 8536.0217,9190.9734 8535.7577,10731.557 8686.7927,10557.548 8837.8267,10383.54 8988.8611,10209.531 8989.2649,8842.5151 8988.9447,7475.4987 8989.047,6108.4822 9140.1435,6108.0405 9291.2397,6107.5989 9442.3362,6107.1572 9442.3362,7300.4639 9442.3362,8493.7709 9442.3362,9687.0778 9593.3708,9513.0693 9744.4053,9339.0612 9895.4399,9165.0527 9895.8697,8145.3129 9895.5047,7125.5723 9895.6258,6105.8322 10046.589,6105.3909 10197.553,6104.9496 10348.516,6104.5083 10349.44,6950.5371 10348.654,7796.5691 10348.915,8642.5995 10499.95,8468.591 10650.984,8294.5825 10802.019,8120.574 10802.429,7448.11 10802.097,6775.6461 10802.204,6103.1821 10953.301,6102.7404 11104.397,6102.2988 11255.493,6101.8571 11255.493,6600.6117 11255.493,7099.3662 11255.493,7598.1207 11406.528,7424.1123 11557.563,7250.1038 11708.597,7076.0954 11708.881,6750.9077 11708.758,6425.7198 11708.783,6100.532 11991.693,6099.705 12274.603,6098.8781 12557.513,6098.0511 12425.761,6249.8434 12294.01,6401.6357 12162.258,6553.428 12162.195,6402.021 12162.05,6250.614 12162.072,6099.207 12162.072,6127.8203 12162.072,6190.6748 12162.072,6198.7311 12162.072,6165.5564 12162.072,6132.3817 12162.072,6099.207 Z"
+     inkstitch:stroke_method="manual_stitch" /></g></g>
+</svg>

lib/elements/stroke.py

@@ -520,7 +520,7 @@ class Stroke(EmbroideryElement):
             return paths
 
         # path to linestrings
-        line_strings = [shgeo.LineString(path) for path in paths]
+        line_strings = [shgeo.LineString(path) for path in paths if len(path) > 1]
         try:
             intersection = self.clip_shape.intersection(shgeo.MultiLineString(line_strings))
         except GEOSException:

templates/select_elements.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<inkscape-extension xmlns="http://www.inkscape.org/namespace/inkscape/extension">
+<inkscape-extension translationdomain="inkstitch" xmlns="http://www.inkscape.org/namespace/inkscape/extension">
     <name>Select embroidery elements</name>
     <id>org.{{ id_inkstitch }}.select_elements</id>
     <param name="extension" type="string" gui-hidden="true">select_elements</param>

templates/transform_elements.xml

@@ -23,8 +23,8 @@
 
     <effect>
         <object-type>all</object-type>
-        <icon>{{ icon_path }}inx/break_apart_fill.svg</icon>
-        <menu-tip>Break apart and repair (broken) fill shapes</menu-tip>
+        <icon>{{ icon_path }}inx/transform.svg</icon>
+        <menu-tip>Rotate or flip embroidery elements while also transforming stitch angles.</menu-tip>
         <effects-menu>
             <submenu name="{{ menu_inkstitch }}" translatable="no">
                 <submenu name="Edit" />

translations/messages_hu_HU.po

@@ -3,7 +3,7 @@ msgstr ""
 "Project-Id-Version: inkstitch\n"
 "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
 "POT-Creation-Date: 2025-09-01 01:55+0000\n"
-"PO-Revision-Date: 2025-09-13 01:25\n"
+"PO-Revision-Date: 2025-09-23 01:31\n"
 "Last-Translator: \n"
 "Language-Team: Hungarian\n"
 "MIME-Version: 1.0\n"
@@ -155,7 +155,7 @@ msgstr "A Syafrizal, más néven Khurasan jawn. 3.5 mm-es szaténöltés 100%-os
 #. description of font in fonts/braille
 #: inkstitch-fonts-metadata.py:52
 msgid "Font for the visually impaired with Braille key combinations according to DT 2024 INSEI specifications for French 6 dots Braille. It is also possible to use Unicode Braille. In this case, it is convenient to use one of the web's Braille translators to create a text in Braille unicode.\n"
-msgstr "Betűtípus látássérültek számára, a DT 2024 INSEI előírásai szerinti francia 6 pontos Braille billentyűkombinációkkal. Unicode Braille használata is lehetséges. Ebben az esetben célszerű a weben elérhető egyik Braille-fordítóval elkészíteni a Braille Unicode szöveget."
+msgstr "Betűtípus látássérültek számára, a DT 2024 INSEI előírásai szerinti francia 6 pontos Braille billentyűkombinációkkal. Unicode Braille használata is lehetséges. Ebben az esetben célszerű a weben elérhető egyik Braille-fordítóval elkészíteni a Braille Unicode szöveget.\n"
 
 #. description of font in fonts/califragilistic
 #: inkstitch-fonts-metadata.py:54